From: Alan Previn <alan.previn.teres.alexis@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: [igt-dev] [PATCH i-g-t 00/17] Introduce PXP Test
Date: Tue, 18 May 2021 03:33:27 -0700 [thread overview]
Message-ID: <20210518103344.2264397-1-alan.previn.teres.alexis@intel.com> (raw)
This series adds gem_pxp tests for the new PXP subsystem currently
being reviewed at https://patchwork.freedesktop.org/series/86798/ .
This series currently includes 4 groups of tests addressing the
features and restrictions described by Daniele's series :
1. test i915 interfaces for allocation of protected bo's
and contexts and enforcement of UAPI rule disallowing the
modification of parameters after it's been created.
2. verify PXP subsystem protected sessions generate encrypted
content on protected output buffers and decrypt protected
inputs buffers.
3. verify i915 PXP auto-teardown succeeds on suspend-resume
cycles and gem-exec of stale protected assets fail. Ensure
protected-contexts adhere to stricter invalidation
enforcement upon teardown event.
4. Ensure that display plane decryption works as expected with
protected buffers with and without HDCP.
NOTE: Although this series is on a fifth revision, this feature
has not been merged into the kernel yet. One final revision may
be necesssary depending on whether additional UAPI changes are
made on the kernel series. Additionally, if ioctl wrapper for
GEM_CREATE_EXT is merged in first, it would be dropped from this
series first.
Changes from prior rev1 to now:
v5:
- Addressed all rev4 review comments. No changes to
overall flow and logic compared to the last rev.
v4:
- Addressed all rev3 review comments. NOTE: that all
test cases and code logic are the same but a decent
amount of refactoring has occured due to address
v3 comments to break out subtests into separate
functions while combining certain checks into the same
function to reduce test time by minimizing number of
suspend-resume power cycles.
v3:
- Addressed all rev2 review comments.
- In line with one of the rev2 comments, a thorough fixup
of all line-breaks in function calls was made for a more
consistent styling.
- Rebased on igt upstream repo and updated to latest kernel
UAPI that added GEM_CREATE_EXT.
v2:
- Addressed all rev1 review comments except these:
1.Chris Wilson : "...have the caller do 1-3 once for its protected
context. Call it something like intel_bb_enable_pxp(),
intel_bb_set_pxp if it should be reversible.".
- This couldn't be implemented because [1] HW needs different
instruction sequences for enabling/disabling PXP depending
on the engine class and [2] the pair of "pxp-enable" and "pxp-
disable" instructions need to be contained within the same batch
that is dispatched to the hardware. That said, implementing
internal intel_batchbuffer funtionality for this would conflict
with how rendercopy_gen9 uses batch buffer memory by repositioing
the pointer and consuming unused portions of the batch buffer as
3d state offsets that batchbuffer has no visibility.
- Added these additional subtests:
1. verify that buffer sharing works across testing pxp context.
2. verify teardown bans contexts via DRM_IOCTL_I915_GET_RESET_STAT.
3. verify display plane decryption of protected buffers.
Alan Previn (16):
Sync i915_drm.h UAPI from kernel
Add PXP UAPI support in i915_drm.h
Update IOCTL wrapper with DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT
Add basic PXP testing of buffer and context alloc
Perform a regular 3d copy as a control checkpoint
Add PXP attribute support in batchbuffer and buffer_ops libs
Add MI_SET_APPID instruction definition
Enable protected session cmd in gen12_render_copyfunc
Add subtest to copy raw source to protected dest
Add test where both src and dest are protected
Verify PXP teardown occurred through suspend-resume
Verify execbuf fails with stale PXP context after teardown
Verify execbuf fails with stale PXP buffer after teardown
Verify execbuf ok with stale prot-buff and regular context
Ensure RESET_STATS reports invalidated protected context
Verify protected surfaces are dma buffer sharable
Karthik B S (1):
tests/i915_pxp: CRC validation for display tests.
include/drm-uapi/i915_drm.h | 448 +++++++++++-
lib/intel_batchbuffer.c | 23 +-
lib/intel_batchbuffer.h | 31 +
lib/intel_bufops.h | 15 +
lib/intel_reg.h | 9 +
lib/ioctl_wrappers.c | 34 +
lib/ioctl_wrappers.h | 2 +
lib/rendercopy_gen9.c | 72 +-
tests/i915/gem_pxp.c | 1318 +++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
10 files changed, 1910 insertions(+), 43 deletions(-)
create mode 100644 tests/i915/gem_pxp.c
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2021-05-18 10:33 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 10:33 Alan Previn [this message]
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 01/17] Sync i915_drm.h UAPI from kernel Alan Previn
2021-06-02 20:07 ` Rodrigo Vivi
2021-06-03 0:15 ` Teres Alexis, Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 02/17] Add PXP UAPI support in i915_drm.h Alan Previn
2021-06-02 20:10 ` Rodrigo Vivi
2021-06-03 0:50 ` Teres Alexis, Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 03/17] Update IOCTL wrapper with DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT Alan Previn
2021-06-02 20:10 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 04/17] Add basic PXP testing of buffer and context alloc Alan Previn
2021-06-02 20:23 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 05/17] Perform a regular 3d copy as a control checkpoint Alan Previn
2021-06-02 21:37 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 06/17] Add PXP attribute support in batchbuffer and buffer_ops libs Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 07/17] Add MI_SET_APPID instruction definition Alan Previn
2021-06-02 21:40 ` Rodrigo Vivi
2021-06-03 0:54 ` Teres Alexis, Alan Previn
2021-06-03 15:06 ` Rodrigo Vivi
2021-06-03 8:52 ` Michal Wajdeczko
2021-06-03 15:22 ` Teres Alexis, Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 08/17] Enable protected session cmd in gen12_render_copyfunc Alan Previn
2021-06-04 13:16 ` Rodrigo Vivi
2021-06-10 17:36 ` Teres Alexis, Alan Previn
2021-06-10 19:55 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 09/17] Add subtest to copy raw source to protected dest Alan Previn
2021-06-04 13:22 ` Rodrigo Vivi
2021-06-05 1:30 ` Teres Alexis, Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 10/17] Add test where both src and dest are protected Alan Previn
2021-06-04 13:31 ` Rodrigo Vivi
2021-06-05 1:38 ` Teres Alexis, Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 11/17] Verify PXP teardown occurred through suspend-resume Alan Previn
2021-06-03 21:40 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 12/17] Verify execbuf fails with stale PXP context after teardown Alan Previn
2021-06-04 13:38 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 13/17] Verify execbuf fails with stale PXP buffer " Alan Previn
2021-06-03 21:41 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 14/17] Verify execbuf ok with stale prot-buff and regular context Alan Previn
2021-06-04 13:56 ` Rodrigo Vivi
2021-06-05 0:27 ` Teres Alexis, Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 15/17] Ensure RESET_STATS reports invalidated protected context Alan Previn
2021-06-03 21:43 ` Rodrigo Vivi
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 16/17] Verify protected surfaces are dma buffer sharable Alan Previn
2021-06-04 14:18 ` Rodrigo Vivi
2021-06-05 0:45 ` Teres Alexis, Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 17/17] tests/i915_pxp: CRC validation for display tests Alan Previn
2021-06-04 14:40 ` Rodrigo Vivi
2021-06-05 1:07 ` Teres Alexis, Alan Previn
2021-06-10 13:00 ` Shankar, Uma
2021-06-10 14:17 ` Rodrigo Vivi
2021-05-18 11:30 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce PXP Test (rev5) Patchwork
2021-05-18 18:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-02 21:44 ` Rodrigo Vivi
2021-06-03 18:09 ` Teres Alexis, Alan Previn
2021-06-03 18:13 ` Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2021-05-15 23:01 [igt-dev] [PATCH i-g-t 00/17] Introduce PXP Test Alan Previn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518103344.2264397-1-alan.previn.teres.alexis@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.