From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com> To: intel-gfx@lists.freedesktop.org Cc: xen-devel <xen-devel@lists.xenproject.org>, "Demi M. Obenour" <demi@invisiblethingslab.com>, "Jani Nikula" <jani.nikula@linux.intel.com>, "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>, "Rodrigo Vivi" <rodrigo.vivi@intel.com>, "Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>, "Matt Roper" <matthew.d.roper@intel.com>, "Lucas De Marchi" <lucas.demarchi@intel.com>, "José Roberto de Souza" <jose.souza@intel.com> Subject: i915 and PAT attributes on Xen PV Date: Thu, 8 Dec 2022 14:55:02 +0100 [thread overview] Message-ID: <Y5Hst0bCxQDTN7lK@mail-itl> (raw) [-- Attachment #1: Type: text/plain, Size: 2242 bytes --] Hi, There is an issue with i915 on Xen PV (dom0). The end result is a lot of glitches, like here: https://openqa.qubes-os.org/tests/54748#step/startup/8 (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's using Xorg with "modesetting" driver. After some iterations of debugging, we narrowed it down to i915 handling caching. The main difference is that PAT is setup differently on Xen PV than on native Linux. Normally, Linux does have appropriate abstraction for that, but apparently something related to i915 doesn't play well with it. The specific difference is: native linux: x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT xen pv: x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC ~~ ~~ ~~ ~~ The specific impact depends on kernel version and the hardware. The most severe issues I see on >=ADL, but some older hardware is affected too - sometimes only if composition is disabled in the window manager. Some more information is collected at https://github.com/QubesOS/qubes-issues/issues/4782 (and few linked duplicates...). Kind-of related commit is here: https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") - it is the place where i915 explicitly checks for PAT support, so I'm cc-ing people mentioned there too. Any ideas? The issue can be easily reproduced without Xen too, by adjusting PAT in Linux: -----8<----- diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index 66a209f7eb86..319ab60c8d8c 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -400,8 +400,8 @@ void pat_init(void) * The reserved slots are unused, but mapped to their * corresponding types in the presence of PAT errata. */ - pat = PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, UC) | - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, WT); + pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7, UC); } if (!pat_bp_initialized) { -----8<----- -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com> To: intel-gfx@lists.freedesktop.org Cc: Lucas De Marchi <lucas.demarchi@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, "Demi M. Obenour" <demi@invisiblethingslab.com>, xen-devel <xen-devel@lists.xenproject.org> Subject: [Intel-gfx] i915 and PAT attributes on Xen PV Date: Thu, 8 Dec 2022 14:55:02 +0100 [thread overview] Message-ID: <Y5Hst0bCxQDTN7lK@mail-itl> (raw) [-- Attachment #1: Type: text/plain, Size: 2242 bytes --] Hi, There is an issue with i915 on Xen PV (dom0). The end result is a lot of glitches, like here: https://openqa.qubes-os.org/tests/54748#step/startup/8 (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's using Xorg with "modesetting" driver. After some iterations of debugging, we narrowed it down to i915 handling caching. The main difference is that PAT is setup differently on Xen PV than on native Linux. Normally, Linux does have appropriate abstraction for that, but apparently something related to i915 doesn't play well with it. The specific difference is: native linux: x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT xen pv: x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC ~~ ~~ ~~ ~~ The specific impact depends on kernel version and the hardware. The most severe issues I see on >=ADL, but some older hardware is affected too - sometimes only if composition is disabled in the window manager. Some more information is collected at https://github.com/QubesOS/qubes-issues/issues/4782 (and few linked duplicates...). Kind-of related commit is here: https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") - it is the place where i915 explicitly checks for PAT support, so I'm cc-ing people mentioned there too. Any ideas? The issue can be easily reproduced without Xen too, by adjusting PAT in Linux: -----8<----- diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index 66a209f7eb86..319ab60c8d8c 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -400,8 +400,8 @@ void pat_init(void) * The reserved slots are unused, but mapped to their * corresponding types in the presence of PAT errata. */ - pat = PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, UC) | - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, WT); + pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7, UC); } if (!pat_bp_initialized) { -----8<----- -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2022-12-08 13:55 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-08 13:55 Marek Marczykowski-Górecki [this message] 2022-12-08 13:55 ` [Intel-gfx] i915 and PAT attributes on Xen PV Marek Marczykowski-Górecki 2022-12-08 16:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2022-12-08 16:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2022-12-16 15:30 ` [cache coherency bug] i915 and PAT attributes Andrew Cooper 2022-12-16 15:30 ` [Intel-gfx] " Andrew Cooper 2022-12-22 8:29 ` Ville Syrjälä 2022-12-22 8:29 ` Ville Syrjälä 2023-01-01 23:24 ` Marek Marczykowski-Górecki 2023-01-02 0:03 ` Demi Marie Obenour 2023-01-02 1:00 ` Marek Marczykowski-Górecki 2023-01-02 1:00 ` Marek Marczykowski-Górecki 2023-01-02 1:17 ` Demi Marie Obenour 2023-01-02 1:17 ` Demi Marie Obenour 2023-01-02 1:48 ` Demi Marie Obenour 2023-01-02 1:48 ` Demi Marie Obenour 2023-01-02 1:58 ` [Intel-gfx] [cache coherency bug] [hw bug?] " Marek Marczykowski-Górecki 2023-01-02 1:58 ` Marek Marczykowski-Górecki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y5Hst0bCxQDTN7lK@mail-itl \ --to=marmarek@invisiblethingslab.com \ --cc=demi@invisiblethingslab.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=jose.souza@intel.com \ --cc=lucas.demarchi@intel.com \ --cc=matthew.d.roper@intel.com \ --cc=rodrigo.vivi@intel.com \ --cc=tvrtko.ursulin@linux.intel.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.