From: Pin-yen Lin <treapking@chromium.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: "Matthias Brugger" <matthias.bgg@gmail.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@lists.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, "Nícolas F . R . A . Prado" <nfraprado@collabora.com>, "open list:ARM/Mediatek SoC support" <linux-kernel@vger.kernel.org>, "Hsin-Te Yuan" <yuanhsinte@chromium.org> Subject: Re: [PATCH] arm64: dts: mediatek: mt8192-asurada: Add off-on-delay-us for pp3300_mipibrdg Date: Tue, 30 Apr 2024 17:32:43 +0800 [thread overview] Message-ID: <CAEXTbpf2HOQj_AxHGbsgOXVF_HyKttL=z7Mi8QStcmuOS+yN7g@mail.gmail.com> (raw) In-Reply-To: <b3c69a78-78c9-4a15-829b-e4b36e16566a@collabora.com> Hi Angelo, On Tue, Apr 30, 2024 at 4:17 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 29/04/24 11:53, Pin-yen Lin ha scritto: > > Set off-on-delay-us to 500000 us for pp3300_mipibrdg to make sure it > > complies with the panel sequence. Explicit configuration on the > > regulator node is required because mt8192-asurada uses the same power > > supply for the panel and the anx7625 DP bridge. So powering on/off the > > DP bridge could break the power sequence requirement for the panel. > > > > Fixes: f9f00b1f6b9b ("arm64: dts: mediatek: asurada: Add display regulators") > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > > > Uhm, there might be more to it - I don't think that this should ever happen. > > The regulator is refcounted, so... > * Bridge on: panel goes off, but regulator doesn't turn off (refcount=1) > * Panel resume -> sequence respected (refcount=2 -> wait -> more vregs, etc) > * Bridge off: panel is already off (refcount=0) > * Bridge resume -> refcount=1, no panel commands yet The off-on-delay could be violated because the bridge driver does not check the delay. > * Panel resume -> refcount=2, wait -> more vregs, etc > > Can you please describe the issue that you're getting? The symptom we observed is that the device has a small chance to reboot to a black panel, and we think the panel's unprepare delay (the time to power down completely) might not be satisfied because the bridge doesn't check that when it enables the regulator. Even if the regulator is enabled by the panel driver, the delay can also be violated in the following sequence: * t=0ms, bridge on: panel goes off, but regulator doesn't turn off (refcount=1). The .unprepared_time in panel_edp is updated * t=300ms, bridge off, regulator goes off (refcount=0) * t=600ms, panel on, the panel driver thinks the unprepare delay (500ms) is satisfied, but the regulator was disabled 300ms ago. Did I miss anything here? Or should I add more detail to the commit message? > > Cheers, > Angelo > Regards, Pin-yen > > --- > > > > arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > index 7a704246678f..08d71ddf3668 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > @@ -147,6 +147,7 @@ pp3300_mipibrdg: regulator-3v3-mipibrdg { > > regulator-boot-on; > > gpio = <&pio 127 GPIO_ACTIVE_HIGH>; > > vin-supply = <&pp3300_g>; > > + off-on-delay-us = <500000>; > > }; > > > > /* separately switched 3.3V power rail */ >
WARNING: multiple messages have this Message-ID (diff)
From: Pin-yen Lin <treapking@chromium.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: "Matthias Brugger" <matthias.bgg@gmail.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@lists.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, "Nícolas F . R . A . Prado" <nfraprado@collabora.com>, "open list:ARM/Mediatek SoC support" <linux-kernel@vger.kernel.org>, "Hsin-Te Yuan" <yuanhsinte@chromium.org> Subject: Re: [PATCH] arm64: dts: mediatek: mt8192-asurada: Add off-on-delay-us for pp3300_mipibrdg Date: Tue, 30 Apr 2024 17:32:43 +0800 [thread overview] Message-ID: <CAEXTbpf2HOQj_AxHGbsgOXVF_HyKttL=z7Mi8QStcmuOS+yN7g@mail.gmail.com> (raw) In-Reply-To: <b3c69a78-78c9-4a15-829b-e4b36e16566a@collabora.com> Hi Angelo, On Tue, Apr 30, 2024 at 4:17 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 29/04/24 11:53, Pin-yen Lin ha scritto: > > Set off-on-delay-us to 500000 us for pp3300_mipibrdg to make sure it > > complies with the panel sequence. Explicit configuration on the > > regulator node is required because mt8192-asurada uses the same power > > supply for the panel and the anx7625 DP bridge. So powering on/off the > > DP bridge could break the power sequence requirement for the panel. > > > > Fixes: f9f00b1f6b9b ("arm64: dts: mediatek: asurada: Add display regulators") > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > > > Uhm, there might be more to it - I don't think that this should ever happen. > > The regulator is refcounted, so... > * Bridge on: panel goes off, but regulator doesn't turn off (refcount=1) > * Panel resume -> sequence respected (refcount=2 -> wait -> more vregs, etc) > * Bridge off: panel is already off (refcount=0) > * Bridge resume -> refcount=1, no panel commands yet The off-on-delay could be violated because the bridge driver does not check the delay. > * Panel resume -> refcount=2, wait -> more vregs, etc > > Can you please describe the issue that you're getting? The symptom we observed is that the device has a small chance to reboot to a black panel, and we think the panel's unprepare delay (the time to power down completely) might not be satisfied because the bridge doesn't check that when it enables the regulator. Even if the regulator is enabled by the panel driver, the delay can also be violated in the following sequence: * t=0ms, bridge on: panel goes off, but regulator doesn't turn off (refcount=1). The .unprepared_time in panel_edp is updated * t=300ms, bridge off, regulator goes off (refcount=0) * t=600ms, panel on, the panel driver thinks the unprepare delay (500ms) is satisfied, but the regulator was disabled 300ms ago. Did I miss anything here? Or should I add more detail to the commit message? > > Cheers, > Angelo > Regards, Pin-yen > > --- > > > > arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > index 7a704246678f..08d71ddf3668 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > @@ -147,6 +147,7 @@ pp3300_mipibrdg: regulator-3v3-mipibrdg { > > regulator-boot-on; > > gpio = <&pio 127 GPIO_ACTIVE_HIGH>; > > vin-supply = <&pp3300_g>; > > + off-on-delay-us = <500000>; > > }; > > > > /* separately switched 3.3V power rail */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-30 9:32 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-29 9:53 [PATCH] arm64: dts: mediatek: mt8192-asurada: Add off-on-delay-us for pp3300_mipibrdg Pin-yen Lin 2024-04-29 9:53 ` Pin-yen Lin 2024-04-30 8:17 ` AngeloGioacchino Del Regno 2024-04-30 8:17 ` AngeloGioacchino Del Regno 2024-04-30 9:32 ` Pin-yen Lin [this message] 2024-04-30 9:32 ` Pin-yen Lin 2024-04-30 9:52 ` AngeloGioacchino Del Regno 2024-04-30 9:52 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAEXTbpf2HOQj_AxHGbsgOXVF_HyKttL=z7Mi8QStcmuOS+yN7g@mail.gmail.com' \ --to=treapking@chromium.org \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=nfraprado@collabora.com \ --cc=yuanhsinte@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.