From: Alexander Wetzel <alexander@wetzel-home.de>
To: Bart Van Assche <bvanassche@acm.org>, dgilbert@interlog.com
Cc: gregkh@linuxfoundation.org, sachinp@linux.ibm.com,
linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
martin.petersen@oracle.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] scsi: sg: Avoid race in error handling & drop bogus warn
Date: Mon, 1 Apr 2024 21:01:52 +0200 [thread overview]
Message-ID: <5bad35f6-70e1-4887-8e31-01e437ba3b94@wetzel-home.de> (raw)
In-Reply-To: <a8b8aabf-250d-46c0-a9b8-fba414e3cfcc@acm.org>
On 01.04.24 19:09, Bart Van Assche wrote:
> On 4/1/24 03:03, Alexander Wetzel wrote:
>> commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
>> introduced an incorrect WARN_ON_ONCE() and missed a sequence where
>> sg_device_destroy() was used after scsi_device_put().
>
> Isn't that too negative? I think that the WARN_ON_ONCE() mentioned above
> has proven to be useful: it helped to catch a bug.
>
It helped to find the other issue. But the WARN_ON_ONCE() here is still
plain wrong. Any only explained by my lack of understanding of the code
and stupid assumptions I should have checked a bit more.
The warning always triggers when we have more than one user of the sg
device (and then free one of them).
While trying to understand the issue I tripped over the other wrong
sequence. Which is probably very seldom really executed...
That said I can of course update the wording when you have a better
suggestion. But I only have some variations of "Ups... sorry. I thought
that was a good idea. Turns out it's not"
>> sg_device_destroy() is accessing the parent scsi_device request_queue
>> which
>> will already be set to NULL when the preceding call to scsi_device_put()
>> removed the last reference to the parent scsi_device.
>>
>> Drop the incorrect WARN_ON_ONCE() - allowing more than one concurrent
>> access to the sg device - and make sure sg_device_destroy() is not used
>> after scsi_device_put() in the error handling.
>>
>> Link:
>> https://lore.kernel.org/all/5375B275-D137-4D5F-BE25-6AF8ACAE41EF@linux.ibm.com
>> Fixes: 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
>
> The "goto sg_put" removed by this patch was introduced by commit
> cc833acbee9d ("sg: O_EXCL and other lock handling"). Since the latter
> commit is older than the one mentioned above, shouldn't the Fixes tag
> refer to the latter commit?
>
The order was not wrong till commit db59133e9279 ("scsi: sg: fix
blktrace debugfs entries leakage"), the one my original patch tried to
fix. Prior to that one sg_device_destroy() was not using the scsi device
request_queue.
I guess I (or one maintainer) could add that commit here again, too...
My reasoning here is, that this patch here fixes what my first patch got
wrong.
Which is already heading into the stable trees. And I would prefer to
not have any kernel release with commit 27f58c04a8f4 ("scsi: sg: Avoid
sg device teardown race") without this fix, too.
>> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
>> index 386981c6976a..833c9277419b 100644
>> --- a/drivers/scsi/sg.c
>> +++ b/drivers/scsi/sg.c
>> @@ -372,8 +372,9 @@ sg_open(struct inode *inode, struct file *filp)
>> error_out:
>> scsi_autopm_put_device(sdp->device);
>> sdp_put:
>> + kref_put(&sdp->d_ref, sg_device_destroy);
>> scsi_device_put(sdp->device);
>> - goto sg_put;
>> + return retval;
>> }
>
> Please add a comment above "return retval" that explains which code will
> drop the sg reference.
>
Hm, don't get that. That kref_put() is the one dropping the reference.
The matching kref_get() is in sg_add_sfp(). Which is called a few lines
prior to the code here (line 350).
The patch is literally only swapping the order of scsi_device_put() and
kref_put().
Which *again* causes a use-after free. So I'll send out v3 immediately
and if any of the thinks discussed here require a v4 we'll do that.
Alexander
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Wetzel <alexander@wetzel-home.de>
To: Bart Van Assche <bvanassche@acm.org>, dgilbert@interlog.com
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
gregkh@linuxfoundation.org, stable@vger.kernel.org,
sachinp@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] scsi: sg: Avoid race in error handling & drop bogus warn
Date: Mon, 1 Apr 2024 21:01:52 +0200 [thread overview]
Message-ID: <5bad35f6-70e1-4887-8e31-01e437ba3b94@wetzel-home.de> (raw)
In-Reply-To: <a8b8aabf-250d-46c0-a9b8-fba414e3cfcc@acm.org>
On 01.04.24 19:09, Bart Van Assche wrote:
> On 4/1/24 03:03, Alexander Wetzel wrote:
>> commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
>> introduced an incorrect WARN_ON_ONCE() and missed a sequence where
>> sg_device_destroy() was used after scsi_device_put().
>
> Isn't that too negative? I think that the WARN_ON_ONCE() mentioned above
> has proven to be useful: it helped to catch a bug.
>
It helped to find the other issue. But the WARN_ON_ONCE() here is still
plain wrong. Any only explained by my lack of understanding of the code
and stupid assumptions I should have checked a bit more.
The warning always triggers when we have more than one user of the sg
device (and then free one of them).
While trying to understand the issue I tripped over the other wrong
sequence. Which is probably very seldom really executed...
That said I can of course update the wording when you have a better
suggestion. But I only have some variations of "Ups... sorry. I thought
that was a good idea. Turns out it's not"
>> sg_device_destroy() is accessing the parent scsi_device request_queue
>> which
>> will already be set to NULL when the preceding call to scsi_device_put()
>> removed the last reference to the parent scsi_device.
>>
>> Drop the incorrect WARN_ON_ONCE() - allowing more than one concurrent
>> access to the sg device - and make sure sg_device_destroy() is not used
>> after scsi_device_put() in the error handling.
>>
>> Link:
>> https://lore.kernel.org/all/5375B275-D137-4D5F-BE25-6AF8ACAE41EF@linux.ibm.com
>> Fixes: 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
>
> The "goto sg_put" removed by this patch was introduced by commit
> cc833acbee9d ("sg: O_EXCL and other lock handling"). Since the latter
> commit is older than the one mentioned above, shouldn't the Fixes tag
> refer to the latter commit?
>
The order was not wrong till commit db59133e9279 ("scsi: sg: fix
blktrace debugfs entries leakage"), the one my original patch tried to
fix. Prior to that one sg_device_destroy() was not using the scsi device
request_queue.
I guess I (or one maintainer) could add that commit here again, too...
My reasoning here is, that this patch here fixes what my first patch got
wrong.
Which is already heading into the stable trees. And I would prefer to
not have any kernel release with commit 27f58c04a8f4 ("scsi: sg: Avoid
sg device teardown race") without this fix, too.
>> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
>> index 386981c6976a..833c9277419b 100644
>> --- a/drivers/scsi/sg.c
>> +++ b/drivers/scsi/sg.c
>> @@ -372,8 +372,9 @@ sg_open(struct inode *inode, struct file *filp)
>> error_out:
>> scsi_autopm_put_device(sdp->device);
>> sdp_put:
>> + kref_put(&sdp->d_ref, sg_device_destroy);
>> scsi_device_put(sdp->device);
>> - goto sg_put;
>> + return retval;
>> }
>
> Please add a comment above "return retval" that explains which code will
> drop the sg reference.
>
Hm, don't get that. That kref_put() is the one dropping the reference.
The matching kref_get() is in sg_add_sfp(). Which is called a few lines
prior to the code here (line 350).
The patch is literally only swapping the order of scsi_device_put() and
kref_put().
Which *again* causes a use-after free. So I'll send out v3 immediately
and if any of the thinks discussed here require a v4 we'll do that.
Alexander
next prev parent reply other threads:[~2024-04-01 19:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 9:08 [powerpc] WARN at drivers/scsi/sg.c:2236 (sg_remove_sfp_usercontext) Sachin Sant
2024-03-29 9:08 ` Sachin Sant
2024-03-29 11:10 ` Alexander Wetzel
2024-03-29 11:10 ` Alexander Wetzel
2024-03-29 14:37 ` Sachin Sant
2024-04-01 9:56 ` [PATCH] scsi: sg: Avoid race in error handling & drop bogus warn Alexander Wetzel
2024-04-01 9:56 ` Alexander Wetzel
2024-04-01 10:03 ` [PATCH v2] " Alexander Wetzel
2024-04-01 10:03 ` Alexander Wetzel
2024-04-01 17:09 ` Bart Van Assche
2024-04-01 17:09 ` Bart Van Assche
2024-04-01 19:01 ` Alexander Wetzel [this message]
2024-04-01 19:01 ` Alexander Wetzel
2024-04-01 19:10 ` [PATCH v3] " Alexander Wetzel
2024-04-01 19:10 ` Alexander Wetzel
2024-04-02 6:01 ` Sachin Sant
2024-04-02 6:01 ` Sachin Sant
2024-04-03 23:24 ` Bart Van Assche
2024-04-03 23:24 ` Bart Van Assche
2024-04-04 6:55 ` Alexander Wetzel
2024-04-04 6:55 ` Alexander Wetzel
2024-04-04 16:34 ` Bart Van Assche
2024-04-04 16:34 ` Bart Van Assche
2024-04-04 22:22 ` Martin K. Petersen
2024-04-04 22:22 ` Martin K. Petersen
2024-04-06 1:58 ` Martin K. Petersen
2024-04-06 1:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bad35f6-70e1-4887-8e31-01e437ba3b94@wetzel-home.de \
--to=alexander@wetzel-home.de \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=sachinp@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.