From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>
Subject: Re: [PATCH] fs: btrfs: Disable BTRFS on platforms having 256K pages
Date: Mon, 10 Jan 2022 08:29:44 +0000 [thread overview]
Message-ID: <3db6dbe8-7190-a2b1-f092-22bbbac6fedd@csgroup.eu> (raw)
In-Reply-To: <6c7a6762-6bec-842b-70b4-4a53297687d1@gmx.com>
Hi Qu,
Le 05/01/2022 à 00:32, Qu Wenruo a écrit :
> Hi Christophe,
>
> I'm recently enhancing the subpage support for btrfs, and my current
> branch should solve the problem for btrfs to support larger page sizes.
>
> But unfortunately my current test environment can only provide page size
> with 64K or 4K, no 16K or 128K/256K support.
>
> Mind to test my new branch on 128K page size systems?
> (256K page size support is still lacking though, which will be addressed
> in the future)
I don't have any system with disk, I only use flashdisks with UBIFS
filesystem.
The reason why I did this commit was because of a build failure reported
by Kernel Build Robot, that's it.
Also note that powerpc doesn't have 128K pages. Only 4/16/64/256.
And for 256 it requires a special version of ld and binutils that I
don't have.
I have a board where I can do 16k pages, but again that board has no disk.
Christophe
>
> https://github.com/adam900710/linux/tree/metadata_subpage_switch
>
> Thanks,
> Qu
>
> On 2021/6/10 13:23, Christophe Leroy wrote:
>> With a config having PAGE_SIZE set to 256K, BTRFS build fails
>> with the following message
>>
>> include/linux/compiler_types.h:326:38: error: call to
>> '__compiletime_assert_791' declared with attribute error: BUILD_BUG_ON
>> failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) != 0
>>
>> BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms with
>> 256K pages at the time being.
>>
>> There are two platforms that can select 256K pages:
>> - hexagon
>> - powerpc
>>
>> Disable BTRFS when 256K page size is selected.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> ---
>> fs/btrfs/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
>> index 68b95ad82126..520a0f6a7d9e 100644
>> --- a/fs/btrfs/Kconfig
>> +++ b/fs/btrfs/Kconfig
>> @@ -18,6 +18,8 @@ config BTRFS_FS
>> select RAID6_PQ
>> select XOR_BLOCKS
>> select SRCU
>> + depends on !PPC_256K_PAGES # powerpc
>> + depends on !PAGE_SIZE_256KB # hexagon
>>
>> help
>> Btrfs is a general purpose copy-on-write filesystem with extents,
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] fs: btrfs: Disable BTRFS on platforms having 256K pages
Date: Mon, 10 Jan 2022 08:29:44 +0000 [thread overview]
Message-ID: <3db6dbe8-7190-a2b1-f092-22bbbac6fedd@csgroup.eu> (raw)
In-Reply-To: <6c7a6762-6bec-842b-70b4-4a53297687d1@gmx.com>
Hi Qu,
Le 05/01/2022 à 00:32, Qu Wenruo a écrit :
> Hi Christophe,
>
> I'm recently enhancing the subpage support for btrfs, and my current
> branch should solve the problem for btrfs to support larger page sizes.
>
> But unfortunately my current test environment can only provide page size
> with 64K or 4K, no 16K or 128K/256K support.
>
> Mind to test my new branch on 128K page size systems?
> (256K page size support is still lacking though, which will be addressed
> in the future)
I don't have any system with disk, I only use flashdisks with UBIFS
filesystem.
The reason why I did this commit was because of a build failure reported
by Kernel Build Robot, that's it.
Also note that powerpc doesn't have 128K pages. Only 4/16/64/256.
And for 256 it requires a special version of ld and binutils that I
don't have.
I have a board where I can do 16k pages, but again that board has no disk.
Christophe
>
> https://github.com/adam900710/linux/tree/metadata_subpage_switch
>
> Thanks,
> Qu
>
> On 2021/6/10 13:23, Christophe Leroy wrote:
>> With a config having PAGE_SIZE set to 256K, BTRFS build fails
>> with the following message
>>
>> include/linux/compiler_types.h:326:38: error: call to
>> '__compiletime_assert_791' declared with attribute error: BUILD_BUG_ON
>> failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) != 0
>>
>> BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms with
>> 256K pages at the time being.
>>
>> There are two platforms that can select 256K pages:
>> - hexagon
>> - powerpc
>>
>> Disable BTRFS when 256K page size is selected.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> ---
>> fs/btrfs/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
>> index 68b95ad82126..520a0f6a7d9e 100644
>> --- a/fs/btrfs/Kconfig
>> +++ b/fs/btrfs/Kconfig
>> @@ -18,6 +18,8 @@ config BTRFS_FS
>> select RAID6_PQ
>> select XOR_BLOCKS
>> select SRCU
>> + depends on !PPC_256K_PAGES # powerpc
>> + depends on !PAGE_SIZE_256KB # hexagon
>>
>> help
>> Btrfs is a general purpose copy-on-write filesystem with extents,
next prev parent reply other threads:[~2022-01-10 8:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 5:23 [PATCH] fs: btrfs: Disable BTRFS on platforms having 256K pages Christophe Leroy
2021-06-10 5:23 ` Christophe Leroy
2021-06-10 13:54 ` [PATCH] " Chris Mason
2021-06-10 13:54 ` Chris Mason
2021-06-10 14:50 ` Christophe Leroy
2021-06-10 14:50 ` Christophe Leroy
2021-06-10 16:20 ` David Sterba
2021-06-10 16:20 ` David Sterba
2021-06-11 12:58 ` Chris Mason
2021-06-11 12:58 ` Chris Mason
2021-06-11 13:21 ` David Sterba
2021-06-11 13:21 ` David Sterba
2021-06-11 16:56 ` Chris Mason
2021-06-11 16:56 ` Chris Mason
2021-06-12 14:44 ` Brian Cain
2021-06-12 14:44 ` Brian Cain
2021-06-11 12:34 ` [PATCH] fs: " David Sterba
2021-06-11 12:34 ` David Sterba
2021-06-11 13:47 ` Qu Wenruo
2021-06-11 13:47 ` Qu Wenruo
2022-01-04 23:32 ` Qu Wenruo
2022-01-04 23:32 ` Qu Wenruo
2022-01-06 16:31 ` Neal Gompa
2022-01-06 16:31 ` Neal Gompa
2022-01-07 0:13 ` Qu Wenruo
2022-01-07 0:13 ` Qu Wenruo
2022-01-07 2:45 ` Hector Martin
2022-01-07 2:45 ` Hector Martin
2022-01-07 4:55 ` Michael Ellerman
2022-01-07 4:55 ` Michael Ellerman
2022-01-07 5:21 ` Qu Wenruo
2022-01-07 5:21 ` Qu Wenruo
2022-01-10 8:29 ` Christophe Leroy [this message]
2022-01-10 8:29 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3db6dbe8-7190-a2b1-f092-22bbbac6fedd@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.