From: Oleksii <oleksii.kurochko@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME
Date: Thu, 16 Feb 2023 14:09:14 +0200 [thread overview]
Message-ID: <29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com> (raw)
In-Reply-To: <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com>
On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote:
> On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote:
> > On 15.02.2023 18:59, Oleksii wrote:
> > > Hello Jan and community,
> > >
> > > I experimented and switched RISC-V to x86 implementation. All
> > > that
> > > I
> > > changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT.
> > > Other
> > > things are the same as for x86.
> > >
> > > For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT
> > > will
> > > look like:
> > >
> > > #define _ASM_BUGFRAME_TEXT(second_frame) \
> > > ".Lbug%=: ebreak\n"
> > > ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n"
> > > ".p2align 2\n"
> > > ".Lfrm%=:\n"
> > > ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n"
> > > ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n"
> > > ".if " #second_frame "\n"
> > > ".long 0, %[bf_msg] - .Lfrm%=\n"
> > > ".endif\n"
> > > ".popsection\n"
> >
> > I expect this could be further abstracted such that only the actual
> > instruction is arch-specific.
> Generally, the only thing that can't be abstracted ( as you mentioned
> is an instruction ).
>
> So we can make additional defines:
> 1. #define MODIFIER "" or "c" (depends on architecture) and use it
>
> the following way:
> ".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\",
> @progbits\n"
> ...
> 2. #define BUG_INSTR "ebreak" | "ud2" | "..." and use it in the
> following way:
> ".Lbug%=: "BUG_ISNTR"\n"
> ...
> Except for these defines which should be specified for each
> architecture
> all other code will be the same for all architectures.
>
> But as I understand with modifier 'c' can be issues that not all
> compilers support but for ARM and x86 before immediate is present
> punctuation # or $ which are removed by modifier 'c'. And I am
> wondering what other ways to remove punctuation before immediate
> exist.
>
> Do you think we should consider that as an issue?
>
> >
> > > The only thing I am worried about is:
> > >
> > > #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \
> > > [bf_type] "i" (type), ...
> > > because as I understand it can be an issue with 'i' modifier in
> > > case of
> > > PIE. I am not sure that Xen enables PIE somewhere but still...
> > > If it is not an issue then we can use x86 implementation as a
> > > generic
> > > one.
> >
> > "i" is not generally an issue with PIE, it only is when the value
> > is
> > the
> > address of a symbol. Here "type" is a constant in all cases. (Or
> > else
> > how would you express an immediate operand of an instruction in an
> > asm()?)
> Hmm. I don't know other ways to express an immediate operand except
> 'i'.
>
> It looks like type, line, msg are always 'constants'
> (
> they possibly can be passed without 'i' and used directly inside
> asm():
> ...
> ".pushsection .bug_frames." __stringify(type) ", \"a\",
> %progbits\n"\
> ...
> ) but the issue will be with 'ptr' for which we have to use 'i'.
>
> And I am not sure about all 'constants'. For example, I think that it
> can be an issue with 'line' = '((line & ((1 << BUG_LINE_LO_WIDTH) -
> 1))
> << BUG_DISP_WIDTH)' if we will use that directly inside asm(...).
>
I think we can avoid 'i' by using 'r' + some kind of mov instruction to
write a register value to memory. The code below is pseudo-code:
#define _ASM_BUGFRAME_TEXT(second_frame)
...
"loc_disp:\n"
" .long 0x0"
"mov [loc_disp], some_register"
...
And the we have to define mov for each architecture.
\
> >
> > Jan
>
> ~ Oleksii
next prev parent reply other threads:[~2023-02-16 12:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 17:05 [PATCH v1 0/4] introduce generic implementation of macros from bug.h Oleksii Kurochko
2023-02-03 17:05 ` [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Oleksii Kurochko
2023-02-13 12:24 ` Jan Beulich
2023-02-13 13:19 ` Julien Grall
2023-02-13 13:30 ` Jan Beulich
2023-02-13 13:56 ` Julien Grall
2023-02-13 15:02 ` Jan Beulich
2023-02-13 15:07 ` Julien Grall
2023-02-13 15:14 ` Jan Beulich
2023-02-13 13:33 ` Andrew Cooper
2023-02-13 13:55 ` Julien Grall
2023-02-14 16:22 ` Oleksii
2023-02-14 16:55 ` Jan Beulich
2023-02-15 15:06 ` Oleksii
2023-02-15 17:59 ` Oleksii
2023-02-16 7:31 ` Jan Beulich
2023-02-16 10:44 ` Oleksii
2023-02-16 12:09 ` Oleksii [this message]
2023-02-16 12:19 ` Andrew Cooper
2023-02-16 20:44 ` Oleksii
2023-02-17 7:12 ` Jan Beulich
2023-02-17 9:33 ` Oleksii
2023-02-16 14:55 ` Jan Beulich
2023-02-16 10:48 ` Andrew Cooper
2023-02-16 12:21 ` Oleksii
2023-02-16 14:53 ` Jan Beulich
2023-02-03 17:05 ` [PATCH v1 2/4] xen/arm: switch ARM to use generic implementation of bug.h Oleksii Kurochko
2023-02-13 13:02 ` Jan Beulich
2023-02-14 16:28 ` Oleksii
2023-02-03 17:05 ` [PATCH v1 3/4] xen/x86: switch x86 to use generic implemetation " Oleksii Kurochko
2023-02-13 13:10 ` Jan Beulich
2023-02-14 16:41 ` Oleksii
2023-02-03 17:05 ` [PATCH v1 4/4] xen: change <asm/bug.h> to <xen/bug.h> Oleksii Kurochko
2023-02-13 13:13 ` Jan Beulich
2023-02-14 16:44 ` Oleksii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.