From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Eric Sandeen <sandeen@redhat.com>, Zorro Lang <zlang@kernel.org>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 6/6] xfs: don't run tests that require v4 file systems when not supported
Date: Wed, 10 Apr 2024 08:05:21 -0700 [thread overview]
Message-ID: <20240410150521.GU6390@frogsfrogsfrogs> (raw)
In-Reply-To: <20240410041402.GB2208@lst.de>
On Wed, Apr 10, 2024 at 06:14:02AM +0200, Christoph Hellwig wrote:
> On Tue, Apr 09, 2024 at 08:56:12AM -0700, Darrick J. Wong wrote:
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> > > common/xfs | 10 ++++++++++
> > > tests/xfs/002 | 1 +
> >
> > Looks fine to me.
> >
> > > tests/xfs/045 | 1 +
> >
> > xfs_db can change uuids on v5 filesystems now, so we don't nee the
> > -mcrc=0 in this test.
>
> Ok, I'll look into that.
>
> > Looks fine to me.
> >
> > > tests/xfs/148 | 2 ++
> >
> > I wonder if we could rewrite this test to use either the xfs_db write -d
> > command on dirents or attrs directly; or the link/attrset commands,
> > since AFAICT the dir/attr code doesn't itself run namecheck when
> > creating entries/attrs.
>
> Can I leave that to you? :)
Yes.
> > > tests/xfs/158 | 1 +
> > > tests/xfs/160 | 1 +
> >
> > inobtcount and bigtime are new features, maybe these two tests should
> > lose the clause that checks that we can't upgrade a V4 filesystem?
>
> I'll take a look.
>
> > > tests/xfs/194 | 2 ++
> >
> > Not sure why this one is fixated on $pagesize/8. Was that a requirement
> > to induce an error? Or would this work just as well on a 1k fsblock fs?
> >
> > (Eric?)
>
> I can check if it could be made to work on $pagesize/4, but I'll
> need to defer to Eric if that even makes sense.
>
> > > tests/xfs/513 | 1 +
> >
> > I think we should split this into separate tests for V4/V5 options and
> > only _require_xfs_nocrc the one with V4 options, because I wouldn't want
> > to stop testing V5 codepaths simply because someone turned off V4
> > support in the kernle.
>
> Ok.
>
> > > tests/xfs/526 | 1 +
> >
> > I'm at a loss on this one -- what it does is useful, but there aren't
> > any V5 mkfs options that conflict as nicely as crc=0 does.
>
> Yes, I tried to look for conflicting options, but I couldn't find
> anything. Maybe we'll grow some before the v4 support is retired
> for real :)
Well hilariously just yesterday djwong-wtf just grew one now that you
can't format rtgroups=1 without exchange=1 so I guess there's some hope.
--D
--D
next prev parent reply other threads:[~2024-04-10 15:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 13:32 fix kernels without v5 support Christoph Hellwig
2024-04-08 13:32 ` [PATCH 1/6] xfs: remove support for tools and kernels with " Christoph Hellwig
2024-04-08 15:03 ` Eric Biggers
2024-04-08 15:04 ` Christoph Hellwig
2024-04-09 15:26 ` Darrick J. Wong
2024-04-29 9:34 ` Chandan Babu R
2024-04-29 9:53 ` Christoph Hellwig
2024-04-29 14:20 ` Zorro Lang
2024-04-08 13:32 ` [PATCH 2/6] remove xfs/096 Christoph Hellwig
2024-04-09 15:27 ` Darrick J. Wong
2024-04-08 13:32 ` [PATCH 3/6] xfs/078: remove the 512 byte block size sub-case Christoph Hellwig
2024-04-09 15:32 ` Darrick J. Wong
2024-04-08 13:32 ` [PATCH 4/6] xfs/263: remove the nocrc sub-test Christoph Hellwig
2024-04-09 15:57 ` Darrick J. Wong
2024-04-10 4:11 ` Christoph Hellwig
2024-04-08 13:32 ` [PATCH 5/6] xfs/522: use reflink instead of crc as test feature Christoph Hellwig
2024-04-09 15:39 ` Darrick J. Wong
2024-04-08 13:32 ` [PATCH 6/6] xfs: don't run tests that require v4 file systems when not supported Christoph Hellwig
2024-04-09 15:56 ` Darrick J. Wong
2024-04-10 4:14 ` Christoph Hellwig
2024-04-10 15:05 ` Darrick J. Wong [this message]
2024-04-08 14:55 ` fix kernels without v5 support Zorro Lang
2024-04-08 14:59 ` Christoph Hellwig
2024-04-08 19:00 ` Zorro Lang
2024-04-10 14:42 ` Zorro Lang
2024-04-10 14:51 ` Christoph Hellwig
2024-04-10 15:16 ` Darrick J. Wong
2024-04-10 15:18 ` Christoph Hellwig
2024-04-10 16:03 ` Darrick J. Wong
2024-04-10 19:38 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410150521.GU6390@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.