From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J . Wong " <djwong@kernel.org>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 3/6] xfs/078: remove the 512 byte block size sub-case
Date: Mon, 8 Apr 2024 15:32:40 +0200 [thread overview]
Message-ID: <20240408133243.694134-4-hch@lst.de> (raw)
In-Reply-To: <20240408133243.694134-1-hch@lst.de>
512 byte block sizes are only supported for v4 file systems, and
xfs/078 crudely forces use of v4 file systems for it. This doesn't
work if the kernel is built without v4 support. Given that v4
support is slowly being phased out and 512 byte block sizes have never
been common, drop this part of the test.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/xfs/078 | 9 ++-------
tests/xfs/078.out | 18 ------------------
2 files changed, 2 insertions(+), 25 deletions(-)
diff --git a/tests/xfs/078 b/tests/xfs/078
index 1f475c963..501551e5e 100755
--- a/tests/xfs/078
+++ b/tests/xfs/078
@@ -69,12 +69,8 @@ _grow_loop()
echo
echo "*** mkfs loop file (size=$original)"
- mkfs_crc_opts=""
- if [ $bsize -lt 1024 -a -z "$XFS_MKFS_HAS_NO_META_SUPPORT" ]; then
- mkfs_crc_opts="-m crc=0"
- fi
- $MKFS_XFS_PROG $mkfs_crc_opts -b size=$bsize $dparam $LOOP_DEV \
- | _filter_mkfs 2>/dev/null
+ $MKFS_XFS_PROG -b size=$bsize $dparam $LOOP_DEV | \
+ _filter_mkfs 2>/dev/null
echo "*** extend loop file"
_destroy_loop_device $LOOP_DEV
@@ -104,7 +100,6 @@ _grow_loop $((168024*4096)) 1376452608 4096 1
# Some other blocksize cases...
_grow_loop $((168024*2048)) 1376452608 2048 1
-_grow_loop $((168024*512)) 1376452608 512 1 16m
_grow_loop $((168024*1024)) 688230400 1024 1
# Other corner cases suggested by dgc
diff --git a/tests/xfs/078.out b/tests/xfs/078.out
index cc3c47d13..7bf5ed03e 100644
--- a/tests/xfs/078.out
+++ b/tests/xfs/078.out
@@ -37,24 +37,6 @@ data blocks changed from 168024 to 672096
*** unmount
*** check
-=== GROWFS (from 86028288 to 1376452608, 512 blocksize)
-
-*** mkfs loop file (size=86028288)
-meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks
-data = bsize=XXX blocks=XXX, imaxpct=PCT
- = sunit=XXX swidth=XXX, unwritten=X
-naming =VERN bsize=XXX
-log =LDEV bsize=XXX blocks=XXX
-realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
-*** extend loop file
-wrote 512/512 bytes at offset 1376452608
-*** mount loop filesystem
-*** grow loop filesystem
-xfs_growfs --BlockSize=512 --Blocks=163840
-data blocks changed from 163840 to 2688384
-*** unmount
-*** check
-
=== GROWFS (from 172056576 to 688230400, 1024 blocksize)
*** mkfs loop file (size=172056576)
--
2.39.2
next prev parent reply other threads:[~2024-04-08 13:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 13:32 fix kernels without v5 support Christoph Hellwig
2024-04-08 13:32 ` [PATCH 1/6] xfs: remove support for tools and kernels with " Christoph Hellwig
2024-04-08 15:03 ` Eric Biggers
2024-04-08 15:04 ` Christoph Hellwig
2024-04-09 15:26 ` Darrick J. Wong
2024-04-29 9:34 ` Chandan Babu R
2024-04-29 9:53 ` Christoph Hellwig
2024-04-29 14:20 ` Zorro Lang
2024-04-08 13:32 ` [PATCH 2/6] remove xfs/096 Christoph Hellwig
2024-04-09 15:27 ` Darrick J. Wong
2024-04-08 13:32 ` Christoph Hellwig [this message]
2024-04-09 15:32 ` [PATCH 3/6] xfs/078: remove the 512 byte block size sub-case Darrick J. Wong
2024-04-08 13:32 ` [PATCH 4/6] xfs/263: remove the nocrc sub-test Christoph Hellwig
2024-04-09 15:57 ` Darrick J. Wong
2024-04-10 4:11 ` Christoph Hellwig
2024-04-08 13:32 ` [PATCH 5/6] xfs/522: use reflink instead of crc as test feature Christoph Hellwig
2024-04-09 15:39 ` Darrick J. Wong
2024-04-08 13:32 ` [PATCH 6/6] xfs: don't run tests that require v4 file systems when not supported Christoph Hellwig
2024-04-09 15:56 ` Darrick J. Wong
2024-04-10 4:14 ` Christoph Hellwig
2024-04-10 15:05 ` Darrick J. Wong
2024-04-08 14:55 ` fix kernels without v5 support Zorro Lang
2024-04-08 14:59 ` Christoph Hellwig
2024-04-08 19:00 ` Zorro Lang
2024-04-10 14:42 ` Zorro Lang
2024-04-10 14:51 ` Christoph Hellwig
2024-04-10 15:16 ` Darrick J. Wong
2024-04-10 15:18 ` Christoph Hellwig
2024-04-10 16:03 ` Darrick J. Wong
2024-04-10 19:38 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408133243.694134-4-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.