From: Lukasz Luba <lukasz.luba@arm.com> To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH v3 0/4] Update Energy Model after chip binning adjusted voltages Date: Thu, 28 Mar 2024 08:51:08 +0000 [thread overview] Message-ID: <20240328085112.3873050-1-lukasz.luba@arm.com> (raw) Hi all, This is a follow-up patch aiming to add EM modification due to chip binning. The first RFC and the discussion can be found here [1]. It uses Exynos chip driver code as a 1st user. The EM framework has been extended to handle this use case easily, when the voltage has been changed after setup. On my Odroid-xu4 in some OPPs I can observe ~20% power difference. According to that data in driver tables it could be up to ~29%. This chip binning is applicable to a lot of SoCs, so the EM framework should make it easy to update. It uses the existing OPP and DT information to re-calculate the new power values. It has dependency on Exynos SoC driver. Changes: v3: - updated header description patch 2/4 (Dietmar) - removed 2 sentences from comment and adjusted in patch 3/4 (Dietmar) - patch 4/4 re-phrased code comment (Dietmar) - collected tags (Krzysztof, Viresh) v2: - removed 'ret' from error message which wasn't initialized (Christian) v1: - exported the OPP calculation function from the OPP/OF so it can be used from EM fwk (Viresh) - refactored EM updating function to re-use common code - added new EM function which can be used by chip device drivers which modify the voltage in OPPs RFC is at [1] Regards, Lukasz Luba Lukasz Luba (4): OPP: OF: Export dev_opp_pm_calc_power() for usage from EM PM: EM: Change the em_adjust_new_capacity() to re-use code PM: EM: Add em_dev_update_chip_binning() soc: samsung: exynos-asv: Update Energy Model after adjusting voltage drivers/opp/of.c | 17 +++-- drivers/soc/samsung/exynos-asv.c | 11 +++- include/linux/energy_model.h | 5 ++ include/linux/pm_opp.h | 8 +++ kernel/power/energy_model.c | 106 +++++++++++++++++++++++++------ 5 files changed, 122 insertions(+), 25 deletions(-) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <lukasz.luba@arm.com> To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH v3 0/4] Update Energy Model after chip binning adjusted voltages Date: Thu, 28 Mar 2024 08:51:08 +0000 [thread overview] Message-ID: <20240328085112.3873050-1-lukasz.luba@arm.com> (raw) Hi all, This is a follow-up patch aiming to add EM modification due to chip binning. The first RFC and the discussion can be found here [1]. It uses Exynos chip driver code as a 1st user. The EM framework has been extended to handle this use case easily, when the voltage has been changed after setup. On my Odroid-xu4 in some OPPs I can observe ~20% power difference. According to that data in driver tables it could be up to ~29%. This chip binning is applicable to a lot of SoCs, so the EM framework should make it easy to update. It uses the existing OPP and DT information to re-calculate the new power values. It has dependency on Exynos SoC driver. Changes: v3: - updated header description patch 2/4 (Dietmar) - removed 2 sentences from comment and adjusted in patch 3/4 (Dietmar) - patch 4/4 re-phrased code comment (Dietmar) - collected tags (Krzysztof, Viresh) v2: - removed 'ret' from error message which wasn't initialized (Christian) v1: - exported the OPP calculation function from the OPP/OF so it can be used from EM fwk (Viresh) - refactored EM updating function to re-use common code - added new EM function which can be used by chip device drivers which modify the voltage in OPPs RFC is at [1] Regards, Lukasz Luba Lukasz Luba (4): OPP: OF: Export dev_opp_pm_calc_power() for usage from EM PM: EM: Change the em_adjust_new_capacity() to re-use code PM: EM: Add em_dev_update_chip_binning() soc: samsung: exynos-asv: Update Energy Model after adjusting voltage drivers/opp/of.c | 17 +++-- drivers/soc/samsung/exynos-asv.c | 11 +++- include/linux/energy_model.h | 5 ++ include/linux/pm_opp.h | 8 +++ kernel/power/energy_model.c | 106 +++++++++++++++++++++++++------ 5 files changed, 122 insertions(+), 25 deletions(-) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2024-03-28 8:51 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-28 8:51 Lukasz Luba [this message] 2024-03-28 8:51 ` [PATCH v3 0/4] Update Energy Model after chip binning adjusted voltages Lukasz Luba 2024-03-28 8:51 ` [PATCH v3 1/4] OPP: OF: Export dev_opp_pm_calc_power() for usage from EM Lukasz Luba 2024-03-28 8:51 ` Lukasz Luba 2024-03-28 8:51 ` [PATCH v3 2/4] PM: EM: Change the em_adjust_new_capacity() to re-use code Lukasz Luba 2024-03-28 8:51 ` Lukasz Luba 2024-03-28 8:51 ` [PATCH v3 3/4] PM: EM: Add em_dev_update_chip_binning() Lukasz Luba 2024-03-28 8:51 ` Lukasz Luba 2024-03-29 8:20 ` kernel test robot 2024-03-29 8:20 ` kernel test robot 2024-03-28 8:51 ` [PATCH v3 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Lukasz Luba 2024-03-28 8:51 ` Lukasz Luba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240328085112.3873050-1-lukasz.luba@arm.com \ --to=lukasz.luba@arm.com \ --cc=alim.akhtar@samsung.com \ --cc=daniel.lezcano@linaro.org \ --cc=dietmar.eggemann@arm.com \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mhiramat@kernel.org \ --cc=nm@ti.com \ --cc=rafael@kernel.org \ --cc=sboyd@kernel.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.