From: "Petr Tesařík" <petr@tesarici.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Petr Tesarik <petrtesarik@huaweicloud.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Petr Tesarik <petr.tesarik1@huawei-partners.com>,
Michael Kelley <mhklinux@outlook.com>,
Will Deacon <will@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:DMA MAPPING HELPERS" <iommu@lists.linux.dev>,
Roberto Sassu <roberto.sassu@huaweicloud.com>
Subject: Re: [PATCH v4 2/2] bug: introduce ASSERT_VAR_CAN_HOLD()
Date: Tue, 26 Mar 2024 12:55:12 +0100 [thread overview]
Message-ID: <20240326125512.430c1ed0@meshulam.tesarici.cz> (raw)
In-Reply-To: <20240326075606.GA10489@lst.de>
On Tue, 26 Mar 2024 08:56:06 +0100
Christoph Hellwig <hch@lst.de> wrote:
> On Mon, Mar 25, 2024 at 09:31:05AM +0100, Petr Tesarik wrote:
> > From: Petr Tesarik <petr.tesarik1@huawei-partners.com>
> >
> > Introduce an ASSERT_VAR_CAN_HOLD() macro to check at build time that a
> > variable can hold the given value.
>
> This really should be run past whoever maintains build_bug.h and
> also cc linux-kernel. Please also split the addition and the user
> in swiotlb into separate patches.
>
> I plan to pick up patch 1 for now, and wait for the discussion on
> this addition.
Fair enough. The use in swiotlb depends on patch 1 from this series,
but you're right, I can send the macro addition as a separate patch to
get some feedback.
Thank you!
Petr T
prev parent reply other threads:[~2024-03-26 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 8:31 [PATCH v4 0/2] swiotlb: allocate padding slots if necessary Petr Tesarik
2024-03-25 8:31 ` [PATCH v4 1/2] swiotlb: extend buffer pre-padding to alloc_align_mask " Petr Tesarik
2024-03-25 19:16 ` Michael Kelley
2024-04-02 15:10 ` Christoph Hellwig
2024-03-25 8:31 ` [PATCH v4 2/2] bug: introduce ASSERT_VAR_CAN_HOLD() Petr Tesarik
2024-03-26 7:56 ` Christoph Hellwig
2024-03-26 11:55 ` Petr Tesařík [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326125512.430c1ed0@meshulam.tesarici.cz \
--to=petr@tesarici.cz \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhklinux@outlook.com \
--cc=petr.tesarik1@huawei-partners.com \
--cc=petrtesarik@huaweicloud.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.