From: Petr Tesarik <petrtesarik@huaweicloud.com>
To: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Petr Tesarik <petr.tesarik1@huawei-partners.com>,
Michael Kelley <mhklinux@outlook.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org (open list),
iommu@lists.linux.dev (open list:DMA MAPPING HELPERS)
Cc: Roberto Sassu <roberto.sassu@huaweicloud.com>,
Petr Tesarik <petr@tesarici.cz>
Subject: [PATCH v4 0/2] swiotlb: allocate padding slots if necessary
Date: Mon, 25 Mar 2024 09:31:03 +0100 [thread overview]
Message-ID: <20240325083105.658-1-petrtesarik@huaweicloud.com> (raw)
From: Petr Tesarik <petr.tesarik1@huawei-partners.com>
If the allocation alignment is bigger than IO_TLB_SIZE and min_align_mask
covers some bits in the original address between IO_TLB_SIZE and
alloc_align_mask, preserve these bits by allocating additional padding
slots before the actual swiotlb buffer.
Changes from v3
---------------
* Add a parameter to swiotlb_align_offset(), so it is not open-coded in
swiotlb_tbl_map_single().
* Extend the description of swiotlb_align_offset() and convert it to the
kernel-doc format.
* Use bit operations to calculate number of padding slots and the padding
inside a slot. This matches all other such calculations in swiotlb.c.
Changes from v2
---------------
* Fix assignment of an uninitialized variable to pad_slots.
* Improve commit message wrt INVALID_PHYS_ADDR.
Changes from v1
---------------
* Rename padding to pad_slots.
* Set pad_slots only for the first allocated non-padding slot.
* Do not bother initializing orig_addr to INVALID_PHYS_ADDR.
* Change list and pad_slots to unsigned short to avoid growing
struct io_tlb_slot on 32-bit targets.
* Add build-time check that list and pad_slots can hold the maximum
allowed value of IO_TLB_SEGSIZE.
Petr Tesarik (2):
swiotlb: extend buffer pre-padding to alloc_align_mask if necessary
bug: introduce ASSERT_VAR_CAN_HOLD()
include/linux/build_bug.h | 10 +++++++
kernel/dma/swiotlb.c | 61 ++++++++++++++++++++++++++++++---------
2 files changed, 58 insertions(+), 13 deletions(-)
--
2.34.1
next reply other threads:[~2024-03-25 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 8:31 Petr Tesarik [this message]
2024-03-25 8:31 ` [PATCH v4 1/2] swiotlb: extend buffer pre-padding to alloc_align_mask if necessary Petr Tesarik
2024-03-25 19:16 ` Michael Kelley
2024-04-02 15:10 ` Christoph Hellwig
2024-03-25 8:31 ` [PATCH v4 2/2] bug: introduce ASSERT_VAR_CAN_HOLD() Petr Tesarik
2024-03-26 7:56 ` Christoph Hellwig
2024-03-26 11:55 ` Petr Tesařík
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325083105.658-1-petrtesarik@huaweicloud.com \
--to=petrtesarik@huaweicloud.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhklinux@outlook.com \
--cc=petr.tesarik1@huawei-partners.com \
--cc=petr@tesarici.cz \
--cc=roberto.sassu@huaweicloud.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.