From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH V7 4/4] soc: imx: Add blk-ctl driver for i.MX8MM
Date: Sat, 26 Jun 2021 17:01:41 +0800 [thread overview]
Message-ID: <202106261631.Dh3Cos1F-lkp@intel.com> (raw)
In-Reply-To: <20210612133134.2738-5-peng.fan@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 2209 bytes --]
Hi "Peng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on next-20210625]
[cannot apply to robh/for-next pza/reset/next v5.13-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Peng-Fan-OSS/soc-imx-add-i-MX-BLK-CTL-support/20210617-013814
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: i386-randconfig-m031-20210625 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/soc/imx/blk-ctl-imx8mm.c:115 imx8mm_blk_ctl_probe() warn: unsigned 'ctl->num_clks' is never less than zero.
vim +115 drivers/soc/imx/blk-ctl-imx8mm.c
89
90 static int imx8mm_blk_ctl_probe(struct platform_device *pdev)
91 {
92 struct device *dev = &pdev->dev;
93 const struct imx_blk_ctl_dev_data *dev_data = of_device_get_match_data(dev);
94 struct regmap *regmap;
95 struct imx_blk_ctl *ctl;
96 void __iomem *base;
97
98 ctl = devm_kzalloc(dev, sizeof(*ctl), GFP_KERNEL);
99 if (!ctl)
100 return -ENOMEM;
101
102 base = devm_platform_ioremap_resource(pdev, 0);
103 if (IS_ERR(base))
104 return PTR_ERR(base);
105
106 regmap = devm_regmap_init_mmio(dev, base, &dev_data->config);
107 if (IS_ERR(regmap))
108 return PTR_ERR(regmap);
109
110 ctl->regmap = regmap;
111 ctl->dev = dev;
112 mutex_init(&ctl->lock);
113
114 ctl->num_clks = devm_clk_bulk_get_all(dev, &ctl->clks);
> 115 if (ctl->num_clks < 0)
116 return ctl->num_clks;
117
118 dev_set_drvdata(dev, ctl);
119 ctl->dev_data = dev_data;
120
121 return imx_blk_ctl_register(dev);
122 }
123
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37606 bytes --]
next prev parent reply other threads:[~2021-06-26 9:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 13:31 [PATCH V7 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
2021-06-12 13:31 ` Peng Fan (OSS)
2021-06-12 13:31 ` [PATCH V7 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains Peng Fan (OSS)
2021-06-12 13:31 ` Peng Fan (OSS)
2021-06-12 13:31 ` [PATCH V7 2/4] dt-bindings: soc: imx: Add bindings for i.MX BLK_CTL Peng Fan (OSS)
2021-06-12 13:31 ` Peng Fan (OSS)
2021-06-12 13:31 ` [PATCH V7 3/4] soc: imx: Add generic blk-ctl driver Peng Fan (OSS)
2021-06-12 13:31 ` Peng Fan (OSS)
2021-06-14 19:43 ` Adam Ford
2021-06-14 19:43 ` Adam Ford
2021-06-17 10:09 ` Aisheng Dong
2021-06-17 10:09 ` Aisheng Dong
2021-06-12 13:31 ` [PATCH V7 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Peng Fan (OSS)
2021-06-12 13:31 ` Peng Fan (OSS)
2021-06-14 18:07 ` Adam Ford
2021-06-14 18:07 ` Adam Ford
2021-06-14 19:29 ` Adam Ford
2021-06-14 19:29 ` Adam Ford
2021-06-15 11:05 ` Peng Fan (OSS)
2021-06-15 11:05 ` Peng Fan (OSS)
2021-06-16 10:34 ` Adam Ford
2021-06-16 10:34 ` Adam Ford
2021-06-16 10:58 ` Peng Fan (OSS)
2021-06-16 10:58 ` Peng Fan (OSS)
2021-06-17 3:14 ` Peng Fan (OSS)
2021-06-17 3:14 ` Peng Fan (OSS)
2021-06-17 12:25 ` Adam Ford
2021-06-17 12:25 ` Adam Ford
2021-06-17 12:33 ` Fabio Estevam
2021-06-17 12:33 ` Fabio Estevam
2021-06-28 10:59 ` Marek Vasut
2021-06-28 10:59 ` Marek Vasut
2021-06-28 11:14 ` Peng Fan
2021-06-28 11:14 ` Peng Fan
2021-06-28 11:18 ` Marek Vasut
2021-06-28 11:18 ` Marek Vasut
2021-06-26 9:01 ` kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-26 8:07 [PATCH V7 3/4] soc: imx: Add generic blk-ctl driver kernel test robot
2021-06-28 8:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106261631.Dh3Cos1F-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.