Hi "Peng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on next-20210625]
[cannot apply to robh/for-next pza/reset/next v5.13-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Peng-Fan-OSS/soc-imx-add-i-MX-BLK-CTL-support/20210617-013814
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: i386-randconfig-m031-20210625 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/soc/imx/blk-ctl-imx8mm.c:115 imx8mm_blk_ctl_probe() warn: unsigned 'ctl->num_clks' is never less than zero.

vim +115 drivers/soc/imx/blk-ctl-imx8mm.c

    89	
    90	static int imx8mm_blk_ctl_probe(struct platform_device *pdev)
    91	{
    92		struct device *dev = &pdev->dev;
    93		const struct imx_blk_ctl_dev_data *dev_data = of_device_get_match_data(dev);
    94		struct regmap *regmap;
    95		struct imx_blk_ctl *ctl;
    96		void __iomem *base;
    97	
    98		ctl = devm_kzalloc(dev, sizeof(*ctl), GFP_KERNEL);
    99		if (!ctl)
   100			return -ENOMEM;
   101	
   102		base = devm_platform_ioremap_resource(pdev, 0);
   103		if (IS_ERR(base))
   104			return PTR_ERR(base);
   105	
   106		regmap = devm_regmap_init_mmio(dev, base, &dev_data->config);
   107		if (IS_ERR(regmap))
   108			return PTR_ERR(regmap);
   109	
   110		ctl->regmap = regmap;
   111		ctl->dev = dev;
   112		mutex_init(&ctl->lock);
   113	
   114		ctl->num_clks = devm_clk_bulk_get_all(dev, &ctl->clks);
 > 115		if (ctl->num_clks < 0)
   116			return ctl->num_clks;
   117	
   118		dev_set_drvdata(dev, ctl);
   119		ctl->dev_data = dev_data;
   120	
   121		return imx_blk_ctl_register(dev);
   122	}
   123	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org