All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [meta-initramfs][PATCH 1/2] initramfs-kexecboot-image: support cases where machines override IMAGE_FSTYPES
@ 2021-06-12 22:53 Andrea Adami
  2021-06-12 22:53 ` [meta-initramfs][PATCH 2/2] initramfs-debug-image: " Andrea Adami
  0 siblings, 1 reply; 2+ messages in thread
From: Andrea Adami @ 2021-06-12 22:53 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Andrea Adami

test case: zaurus.inc

IMAGE_FSTYPES ?= "tar.gz jffs2 jffs2.sum ubi ubifs"
IMAGE_FSTYPES_collie ?= "tar.gz jffs2 jffs2.sum"
INITRAMFS_FSTYPES ?= "cpio.gz cpio.xz"

The last assignment IMAGE_FSTYPES = "${INITRAMFS_FSTYPES}" did in fact
reset the value to IMAGE_FSTYPES_collie, thus not producing cpio.gz / cpio.xz.

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 .../recipes-core/images/initramfs-kexecboot-image.bb      | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/meta-initramfs/recipes-core/images/initramfs-kexecboot-image.bb b/meta-initramfs/recipes-core/images/initramfs-kexecboot-image.bb
index 9a686f366f..dd082ba529 100644
--- a/meta-initramfs/recipes-core/images/initramfs-kexecboot-image.bb
+++ b/meta-initramfs/recipes-core/images/initramfs-kexecboot-image.bb
@@ -1,9 +1,13 @@
 SUMMARY = "Initramfs image for kexecboot kernel"
 DESCRIPTION = "This image provides kexecboot (linux as bootloader) and helpers."
 
-inherit image
+# Some BSPs use IMAGE_FSTYPES_<machine override> which would override
+# an assignment to IMAGE_FSTYPES so we need anon python
+python () {
+    d.setVar("IMAGE_FSTYPES", d.getVar("INITRAMFS_FSTYPES"))
+}
 
-IMAGE_FSTYPES = "${INITRAMFS_FSTYPES}"
+inherit image
 
 # avoid circular dependencies
 EXTRA_IMAGEDEPENDS = ""
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [meta-initramfs][PATCH 2/2] initramfs-debug-image: support cases where machines override IMAGE_FSTYPES
  2021-06-12 22:53 [meta-initramfs][PATCH 1/2] initramfs-kexecboot-image: support cases where machines override IMAGE_FSTYPES Andrea Adami
@ 2021-06-12 22:53 ` Andrea Adami
  0 siblings, 0 replies; 2+ messages in thread
From: Andrea Adami @ 2021-06-12 22:53 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Andrea Adami

As done for initramfs-kexecboot-image we need to use python to get the
desired value for IMAGE_FSTYPES.

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 .../recipes-core/images/initramfs-debug-image.bb           | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta-initramfs/recipes-core/images/initramfs-debug-image.bb b/meta-initramfs/recipes-core/images/initramfs-debug-image.bb
index c3dcd2b821..601056b7e5 100644
--- a/meta-initramfs/recipes-core/images/initramfs-debug-image.bb
+++ b/meta-initramfs/recipes-core/images/initramfs-debug-image.bb
@@ -11,7 +11,12 @@ IMAGE_FEATURES = ""
 export IMAGE_BASENAME = "initramfs-debug-image"
 IMAGE_LINGUAS = ""
 
-IMAGE_FSTYPES = "${INITRAMFS_FSTYPES}"
+# Some BSPs use IMAGE_FSTYPES_<machine override> which would override
+# an assignment to IMAGE_FSTYPES so we need anon python
+python () {
+    d.setVar("IMAGE_FSTYPES", d.getVar("INITRAMFS_FSTYPES"))
+}
+
 inherit core-image
 
 IMAGE_ROOTFS_SIZE = "8192"
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-12 22:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 22:53 [meta-initramfs][PATCH 1/2] initramfs-kexecboot-image: support cases where machines override IMAGE_FSTYPES Andrea Adami
2021-06-12 22:53 ` [meta-initramfs][PATCH 2/2] initramfs-debug-image: " Andrea Adami

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.