All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/seatd: disable -Werror
@ 2021-06-12 21:15 Fabrice Fontaine
  2021-06-13  9:57 ` Adrian Perez de Castro
  2021-07-13 19:47 ` Arnout Vandecappelle
  0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-06-12 21:15 UTC (permalink / raw)
  To: buildroot

Disable -Werror to avoid the following build failure which is raised
since the addition of the package in commit
daae31149017cbf8b03634cfc56da132f7e1ad83

../seatd/seat.c: In function 'seat_activate_device':
../seatd/seat.c:374:48: error: unused parameter 'client' [-Werror=unused-parameter]
  374 | static int seat_activate_device(struct client *client, struct seat_device *seat_device) {
      |                                 ~~~~~~~~~~~~~~~^~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/0ec925aab23d83c52684f5fea7a4395c93a674c4

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/seatd/seatd.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/seatd/seatd.mk b/package/seatd/seatd.mk
index 2abcefbfaa..bf582f0d1d 100644
--- a/package/seatd/seatd.mk
+++ b/package/seatd/seatd.mk
@@ -13,7 +13,8 @@ SEATD_INSTALL_STAGING = YES
 
 SEATD_CONF_OPTS += \
 	-Dman-pages=disabled \
-	-Dexamples=disabled
+	-Dexamples=disabled \
+	-Dwerror=false
 
 ifeq ($(BR2_PACKAGE_SYSTEMD_LOGIND),y)
 SEATD_CONF_OPTS += -Dlogind=enabled
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/seatd: disable -Werror
  2021-06-12 21:15 [Buildroot] [PATCH 1/1] package/seatd: disable -Werror Fabrice Fontaine
@ 2021-06-13  9:57 ` Adrian Perez de Castro
  2021-07-01 21:41   ` Adam Duskett
  2021-07-13 19:47 ` Arnout Vandecappelle
  1 sibling, 1 reply; 4+ messages in thread
From: Adrian Perez de Castro @ 2021-06-13  9:57 UTC (permalink / raw)
  To: buildroot

On Sat, 12 Jun 2021 23:15:02 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Disable -Werror to avoid the following build failure which is raised
> since the addition of the package in commit
> daae31149017cbf8b03634cfc56da132f7e1ad83
> 
> ../seatd/seat.c: In function 'seat_activate_device':
> ../seatd/seat.c:374:48: error: unused parameter 'client' [-Werror=unused-parameter]
>   374 | static int seat_activate_device(struct client *client, struct seat_device *seat_device) {
>       |                                 ~~~~~~~~~~~~~~~^~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/0ec925aab23d83c52684f5fea7a4395c93a674c4
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/seatd/seatd.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/seatd/seatd.mk b/package/seatd/seatd.mk
> index 2abcefbfaa..bf582f0d1d 100644
> --- a/package/seatd/seatd.mk
> +++ b/package/seatd/seatd.mk
> @@ -13,7 +13,8 @@ SEATD_INSTALL_STAGING = YES
>  
>  SEATD_CONF_OPTS += \
>  	-Dman-pages=disabled \
> -	-Dexamples=disabled
> +	-Dexamples=disabled \
> +	-Dwerror=false
>  
>  ifeq ($(BR2_PACKAGE_SYSTEMD_LOGIND),y)
>  SEATD_CONF_OPTS += -Dlogind=enabled
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210613/db4ed2d4/attachment.asc>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/seatd: disable -Werror
  2021-06-13  9:57 ` Adrian Perez de Castro
@ 2021-07-01 21:41   ` Adam Duskett
  0 siblings, 0 replies; 4+ messages in thread
From: Adam Duskett @ 2021-07-01 21:41 UTC (permalink / raw)
  To: buildroot

All;

Tested-by: Adam Duskett <aduskett@gmail.com>

On Sun, Jun 13, 2021 at 2:58 AM Adrian Perez de Castro
<aperez@igalia.com> wrote:
>
> On Sat, 12 Jun 2021 23:15:02 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Disable -Werror to avoid the following build failure which is raised
> > since the addition of the package in commit
> > daae31149017cbf8b03634cfc56da132f7e1ad83
> >
> > ../seatd/seat.c: In function 'seat_activate_device':
> > ../seatd/seat.c:374:48: error: unused parameter 'client' [-Werror=unused-parameter]
> >   374 | static int seat_activate_device(struct client *client, struct seat_device *seat_device) {
> >       |                                 ~~~~~~~~~~~~~~~^~~~~~
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/0ec925aab23d83c52684f5fea7a4395c93a674c4
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
>
> > ---
> >  package/seatd/seatd.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/seatd/seatd.mk b/package/seatd/seatd.mk
> > index 2abcefbfaa..bf582f0d1d 100644
> > --- a/package/seatd/seatd.mk
> > +++ b/package/seatd/seatd.mk
> > @@ -13,7 +13,8 @@ SEATD_INSTALL_STAGING = YES
> >
> >  SEATD_CONF_OPTS += \
> >       -Dman-pages=disabled \
> > -     -Dexamples=disabled
> > +     -Dexamples=disabled \
> > +     -Dwerror=false
> >
> >  ifeq ($(BR2_PACKAGE_SYSTEMD_LOGIND),y)
> >  SEATD_CONF_OPTS += -Dlogind=enabled
> > --
> > 2.30.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/seatd: disable -Werror
  2021-06-12 21:15 [Buildroot] [PATCH 1/1] package/seatd: disable -Werror Fabrice Fontaine
  2021-06-13  9:57 ` Adrian Perez de Castro
@ 2021-07-13 19:47 ` Arnout Vandecappelle
  1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2021-07-13 19:47 UTC (permalink / raw)
  To: buildroot



On 12/06/2021 23:15, Fabrice Fontaine wrote:
> Disable -Werror to avoid the following build failure which is raised
> since the addition of the package in commit
> daae31149017cbf8b03634cfc56da132f7e1ad83
> 
> ../seatd/seat.c: In function 'seat_activate_device':
> ../seatd/seat.c:374:48: error: unused parameter 'client' [-Werror=unused-parameter]
>   374 | static int seat_activate_device(struct client *client, struct seat_device *seat_device) {
>       |                                 ~~~~~~~~~~~~~~~^~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/0ec925aab23d83c52684f5fea7a4395c93a674c4
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  package/seatd/seatd.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/seatd/seatd.mk b/package/seatd/seatd.mk
> index 2abcefbfaa..bf582f0d1d 100644
> --- a/package/seatd/seatd.mk
> +++ b/package/seatd/seatd.mk
> @@ -13,7 +13,8 @@ SEATD_INSTALL_STAGING = YES
>  
>  SEATD_CONF_OPTS += \
>  	-Dman-pages=disabled \
> -	-Dexamples=disabled
> +	-Dexamples=disabled \
> +	-Dwerror=false
>  
>  ifeq ($(BR2_PACKAGE_SYSTEMD_LOGIND),y)
>  SEATD_CONF_OPTS += -Dlogind=enabled
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-13 19:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 21:15 [Buildroot] [PATCH 1/1] package/seatd: disable -Werror Fabrice Fontaine
2021-06-13  9:57 ` Adrian Perez de Castro
2021-07-01 21:41   ` Adam Duskett
2021-07-13 19:47 ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.