From: Chunyou Tang <tangchunyou@163.com>
To: Steven Price <steven.price@arm.com>
Cc: robh@kernel.org, tomeu.vizoso@collabora.com,
alyssa.rosenzweig@collabora.com, airlied@linux.ie,
daniel@ffwll.ch, tangchunyou@icubecorp.cn,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tangchunyou <tangchunyou@163.icubecorp.cn>
Subject: Re: [PATCH] modified: gpu/drm/panfrost/panfrost_gpu.c
Date: Thu, 10 Jun 2021 21:06:59 +0800 [thread overview]
Message-ID: <20210610210659.00003155@163.com> (raw)
In-Reply-To: <78a2488a-71d5-548a-e221-7786f788509c@arm.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GB18030, Size: 2560 bytes --]
Hi Steven,
> > The GPU exception fault status register(0x3C),the low 8 bit is the
> > EXCEPTION_TYPE.We can see the description at P3-78 in spec.
You can see the spec
<arm_heimdall_technical_reference_manual_100612_0001_00_en.pdf>.
> However this change is correct - panfrost_exception_name() should be
> taking only the lower 8 bits. Even better though would be to to report
> the full raw fault information as well as the high bits can contain
> useful information:
>
> dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
> fault_status,
> panfrost_exception_name(pfdev, fault_status & 0xFF),
> address);
So I change it according to what you said?
ÓÚ Thu, 10 Jun 2021 11:41:52 +0100
Steven Price <steven.price@arm.com> дµÀ:
> The subject should have the prefix "drm/panfrost" and should mention
> what the patch is changing (not just the filename).
>
> On 09/06/2021 07:38, ChunyouTang wrote:
> > From: tangchunyou <tangchunyou@163.icubecorp.cn>
> >
> > The GPU exception fault status register(0x3C),the low 8 bit is the
> > EXCEPTION_TYPE.We can see the description at P3-78 in spec.
>
> Nit: When referring to a spec it's always good to mention the name -
> I'm not sure which specification you found this in.
>
> >
> > Signed-off-by: tangchunyou <tangchunyou@163.icubecorp.cn>
> > ---
> > drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> > b/drivers/gpu/drm/panfrost/panfrost_gpu.c index
> > 2aae636f1cf5..1fffb6a0b24f 100644 ---
> > a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++
> > b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -33,7 +33,7 @@ static
> > irqreturn_t panfrost_gpu_irq_handler(int irq, void *data) address
> > |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);
> > dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at
> > 0x%016llx\n",
> > - fault_status & 0xFF,
> > panfrost_exception_name(pfdev, fault_status),
> > + fault_status & 0xFF,
> > panfrost_exception_name(pfdev, fault_status & 0xFF),
>
> However this change is correct - panfrost_exception_name() should be
> taking only the lower 8 bits. Even better though would be to to report
> the full raw fault information as well as the high bits can contain
> useful information:
>
> dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
> fault_status,
> panfrost_exception_name(pfdev, fault_status & 0xFF),
> address);
>
> Thanks,
>
> Steve
>
> > address);
> >
> > if (state & GPU_IRQ_MULTIPLE_FAULT)
> >
WARNING: multiple messages have this Message-ID (diff)
From: Chunyou Tang <tangchunyou@163.com>
To: Steven Price <steven.price@arm.com>
Cc: tangchunyou <tangchunyou@163.icubecorp.cn>,
tomeu.vizoso@collabora.com, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
alyssa.rosenzweig@collabora.com, tangchunyou@icubecorp.cn
Subject: Re: [PATCH] modified: gpu/drm/panfrost/panfrost_gpu.c
Date: Thu, 10 Jun 2021 21:06:59 +0800 [thread overview]
Message-ID: <20210610210659.00003155@163.com> (raw)
In-Reply-To: <78a2488a-71d5-548a-e221-7786f788509c@arm.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GB18030, Size: 2560 bytes --]
Hi Steven,
> > The GPU exception fault status register(0x3C),the low 8 bit is the
> > EXCEPTION_TYPE.We can see the description at P3-78 in spec.
You can see the spec
<arm_heimdall_technical_reference_manual_100612_0001_00_en.pdf>.
> However this change is correct - panfrost_exception_name() should be
> taking only the lower 8 bits. Even better though would be to to report
> the full raw fault information as well as the high bits can contain
> useful information:
>
> dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
> fault_status,
> panfrost_exception_name(pfdev, fault_status & 0xFF),
> address);
So I change it according to what you said?
ÓÚ Thu, 10 Jun 2021 11:41:52 +0100
Steven Price <steven.price@arm.com> дµÀ:
> The subject should have the prefix "drm/panfrost" and should mention
> what the patch is changing (not just the filename).
>
> On 09/06/2021 07:38, ChunyouTang wrote:
> > From: tangchunyou <tangchunyou@163.icubecorp.cn>
> >
> > The GPU exception fault status register(0x3C),the low 8 bit is the
> > EXCEPTION_TYPE.We can see the description at P3-78 in spec.
>
> Nit: When referring to a spec it's always good to mention the name -
> I'm not sure which specification you found this in.
>
> >
> > Signed-off-by: tangchunyou <tangchunyou@163.icubecorp.cn>
> > ---
> > drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> > b/drivers/gpu/drm/panfrost/panfrost_gpu.c index
> > 2aae636f1cf5..1fffb6a0b24f 100644 ---
> > a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++
> > b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -33,7 +33,7 @@ static
> > irqreturn_t panfrost_gpu_irq_handler(int irq, void *data) address
> > |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);
> > dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at
> > 0x%016llx\n",
> > - fault_status & 0xFF,
> > panfrost_exception_name(pfdev, fault_status),
> > + fault_status & 0xFF,
> > panfrost_exception_name(pfdev, fault_status & 0xFF),
>
> However this change is correct - panfrost_exception_name() should be
> taking only the lower 8 bits. Even better though would be to to report
> the full raw fault information as well as the high bits can contain
> useful information:
>
> dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at 0x%016llx\n",
> fault_status,
> panfrost_exception_name(pfdev, fault_status & 0xFF),
> address);
>
> Thanks,
>
> Steve
>
> > address);
> >
> > if (state & GPU_IRQ_MULTIPLE_FAULT)
> >
next prev parent reply other threads:[~2021-06-10 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 6:38 [PATCH] modified: gpu/drm/panfrost/panfrost_gpu.c ChunyouTang
2021-06-09 6:38 ` ChunyouTang
2021-06-10 10:41 ` Steven Price
2021-06-10 13:06 ` Chunyou Tang [this message]
2021-06-10 13:06 ` Chunyou Tang
2021-06-11 10:10 ` Steven Price
2021-06-11 10:10 ` Steven Price
2021-06-11 10:36 ` Chunyou Tang
2021-06-11 10:36 ` Chunyou Tang
2021-06-15 7:04 ` Chunyou Tang
2021-06-15 7:04 ` Chunyou Tang
2021-06-16 11:07 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610210659.00003155@163.com \
--to=tangchunyou@163.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tangchunyou@163.icubecorp.cn \
--cc=tangchunyou@icubecorp.cn \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.