From: Dan Carpenter <dan.carpenter@oracle.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c
Date: Fri, 21 May 2021 13:52:22 +0300 [thread overview]
Message-ID: <20210521105222.GJ1955@kadam> (raw)
In-Reply-To: <6bc123d66150ccaa6dc6fdf2f11c8669e2f493e2.1619850663.git.drv@mailo.com>
On Sat, May 01, 2021 at 12:16:07PM +0530, Deepak R Varma wrote:
> @@ -1562,8 +1544,10 @@ ia_css_isp_3a_statistics_map_allocate(
> base_ptr = me->data_ptr;
>
> me->size = isp_stats->size;
> - /* GCC complains when we assign a char * to a void *, so these
> - * casts are necessary unfortunately. */
> + /*
> + * GCC complains when we assign a char * to a void *, so these
> + * casts are necessary unfortunately.
> + */
Not related to your patch, but assigning a char pointer to a void
pointer is fine and GCC will not complain. The problem is that
me->dmem_stats is not a void pointer. Someone should delete that
nonsense comment.
> me->dmem_stats = (void *)base_ptr;
> me->vmem_stats_hi = (void *)(base_ptr + isp_stats->dmem_size);
> me->vmem_stats_lo = (void *)(base_ptr + isp_stats->dmem_size +
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Deepak R Varma <drv@mailo.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c
Date: Fri, 21 May 2021 13:52:22 +0300 [thread overview]
Message-ID: <20210521105222.GJ1955@kadam> (raw)
In-Reply-To: <6bc123d66150ccaa6dc6fdf2f11c8669e2f493e2.1619850663.git.drv@mailo.com>
On Sat, May 01, 2021 at 12:16:07PM +0530, Deepak R Varma wrote:
> @@ -1562,8 +1544,10 @@ ia_css_isp_3a_statistics_map_allocate(
> base_ptr = me->data_ptr;
>
> me->size = isp_stats->size;
> - /* GCC complains when we assign a char * to a void *, so these
> - * casts are necessary unfortunately. */
> + /*
> + * GCC complains when we assign a char * to a void *, so these
> + * casts are necessary unfortunately.
> + */
Not related to your patch, but assigning a char pointer to a void
pointer is fine and GCC will not complain. The problem is that
me->dmem_stats is not a void pointer. Someone should delete that
nonsense comment.
> me->dmem_stats = (void *)base_ptr;
> me->vmem_stats_hi = (void *)(base_ptr + isp_stats->dmem_size);
> me->vmem_stats_lo = (void *)(base_ptr + isp_stats->dmem_size +
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-05-21 10:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 6:43 [PATCH 0/5] staging: media: atomisp: code formatting changes Deepak R Varma
2021-05-20 19:00 ` [PATCH RESEND " Deepak R Varma
2021-05-20 19:00 ` Deepak R Varma
2021-05-01 6:43 ` [PATCH " Deepak R Varma
2021-05-01 6:44 ` [PATCH 1/5] staging: media: atomisp: code formatting changes atomisp_csi2.c Deepak R Varma
2021-05-20 19:02 ` [PATCH RESEND " Deepak R Varma
2021-05-20 19:02 ` Deepak R Varma
2021-05-01 6:44 ` [PATCH " Deepak R Varma
2021-05-01 6:45 ` [PATCH 2/5] staging: media: atomisp: code formatting changes sh_css_mipi.c Deepak R Varma
2021-05-20 19:03 ` [PATCH RESEND " Deepak R Varma
2021-05-20 19:03 ` Deepak R Varma
2021-05-01 6:45 ` [PATCH " Deepak R Varma
2021-05-01 6:46 ` [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c Deepak R Varma
2021-05-20 19:04 ` [PATCH RESEND " Deepak R Varma
2021-05-20 19:04 ` Deepak R Varma
2021-05-01 6:46 ` [PATCH " Deepak R Varma
2021-05-21 10:52 ` Dan Carpenter [this message]
2021-05-21 10:52 ` Dan Carpenter
2021-05-22 10:24 ` Deepak R Varma
2021-05-22 10:24 ` Deepak R Varma
2021-05-01 6:47 ` [PATCH 4/5] staging: media: atomisp: code formatting changes sh_css_sp.c Deepak R Varma
2021-05-20 19:05 ` [PATCH RESEND " Deepak R Varma
2021-05-20 19:05 ` Deepak R Varma
2021-05-01 6:47 ` [PATCH " Deepak R Varma
2021-05-01 6:48 ` [PATCH 5/5] staging: media: atomisp: code formatting changes sh_css_version.c Deepak R Varma
2021-05-20 19:06 ` [PATCH RESEND " Deepak R Varma
2021-05-20 19:06 ` Deepak R Varma
2021-05-01 6:48 ` [PATCH " Deepak R Varma
2021-06-12 16:43 ` [PATCH RESEND 0/5] staging: media: atomisp: code formatting changes Deepak R Varma
2021-06-12 16:43 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521105222.GJ1955@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.