From: Dave Jones <davej@codemonkey.org.uk>
To: ISHIKAWA Mutsumi <ishikawa@debian.org>
Cc: fendrakyn@europaguild.com, davej@codemonkey.org.uk,
matthew.e.tolentino@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [BUG] E7x05 chipset bug in 2.5 kernels' AGPGART driver.
Date: Thu, 3 Apr 2003 12:28:58 +0100 [thread overview]
Message-ID: <20030403112858.GB15999@suse.de> (raw)
In-Reply-To: <20030403033359.33D8E8DC14@master.hanzubon.jp>
On Thu, Apr 03, 2003 at 12:33:59PM +0900, ISHIKAWA Mutsumi wrote:
> I've checked Intel E7205 and E7505 spec sheets. But I can not find
> why we should use device #1 (virtual agp bridge) instaed of device
> #0 (MCH).
Look at agp_3_0_node_enable()
In particular, the part that does a pci read of PCI_SECONDARY_BUS.
device #1 (AGP bridge) has 1:0.0 (AGP graphic card) as its secondary
bus here. Device #0 (Host bridge) doesn't have anything as a secondary
bus, so it can't mate the card with the bridge. So i7x05 jumps through
hoops using the wrong device in its agp_bridge->dev to get this right.
Its really fugly, and is against what every other gart driver is doing.
In my working tree (not yet pushed to bkbits) I've ripped out that
whole PCI_SECONDARY_BUS thing and replaced it with a simple bus scan
that looks for 2 devices that are AGP host and AGP target and pairs
them unconditionally.
This will probably break if ever someone does a >1 AGP Slot motherboard
but with vendors preffering to just dual-head AGP cards, and with PCI Express
in the pipeline, it's questionable whether or not we'll see them.
I've heard from one vendor who says they're interested in doing such a
board. If it ever sees light of day, it's worth worrying about,
(and this system sounds so niche I doubt it'd ever be mainstream anyway).
> I rewrite E7x05 agpgart driver to use device #0. It
> works fine for me (I tested it on E7505 motherboard with AGPx4
> card and AGPx8 card). To use MCH registers (on device #0) is generic
> way for Intel agpgart driver, so the driver can merge into intel-agp.c
> easyly.
I don't mind either way. If Matt wants to keep this as a seperate
subdriver I'll keep it as it is. If he's ok with the merge, I'll
apply your changes. The only questionable bit is the increase in
size of the respective modules by a few KB.
Thanks for your work..
Dave
next prev parent reply other threads:[~2003-04-03 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-02 18:50 [BUG] E7x05 chipset bug in 2.5 kernels' AGPGART driver Fendrakyn
2003-04-02 22:10 ` Dave Jones
2003-04-03 3:33 ` ISHIKAWA Mutsumi
2003-04-03 11:28 ` Dave Jones [this message]
2003-04-04 7:58 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030403112858.GB15999@suse.de \
--to=davej@codemonkey.org.uk \
--cc=fendrakyn@europaguild.com \
--cc=ishikawa@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.