All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Fendrakyn <fendrakyn@europaguild.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] E7x05 chipset bug in 2.5 kernels' AGPGART driver.
Date: Wed, 2 Apr 2003 23:10:46 +0100	[thread overview]
Message-ID: <20030402221046.GA30881@suse.de> (raw)
In-Reply-To: <200304022050.03026.fendrakyn@europaguild.com>

On Wed, Apr 02, 2003 at 08:50:03PM +0200, Fendrakyn wrote:

 > There is a mistake in the Makefile of drivers/char/agp, the line concerning 
 > i7x05-agp support does not match the one in the Kconfig, thus e7x05 support 
 > is never compiled, be it as a module or in the kernel.

I'm really amazed. This has been broken for months, and no-one noticed.
The day I fixed it in the agpgart bk tree, I got a half dozen reports,
and now I'm getting one daily. Truly bizarre.

 > The last problem is more important and I have yet to find a solution. It seems 
 > like the driver stores device 0 in his agp_bridge->dev (0x255d for E7205, 
 > 0x2550 for E7505) but it uses registers from device 1 (0x2552) thus the 
 > chipset cannot be configured properly. The fetch_size function fails to 
 > determine aperture size.

Yep, the other issues (compile problems) are fixed up and will be going
to Linus real soon now, this problem though is something that is being
looked at by Matt (i7x05 gart driver author) right now.
Hopefully that'll also get fixed up with the changes being readied for 2.5.67

The reason i7x05 does things differently is that the generic-3.0 code
looks at the devices hanging of the device 0 (in that case, agp gfx cards).
I realised last week that the generic code is broken, as every other
agp chipset has the agp cards as secondaries of the agp bridge, not the
host bridge. Rather than fudge things like this, it looks like a lot
of the generic-3.0 stuff will be ripped out. It doesn't really work
properly, and is of questionable use.

 > Sorry if this is redundant and is already being looked at.

No problem 8-)

		Dave


  reply	other threads:[~2003-04-02 21:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-02 18:50 [BUG] E7x05 chipset bug in 2.5 kernels' AGPGART driver Fendrakyn
2003-04-02 22:10 ` Dave Jones [this message]
2003-04-03  3:33   ` ISHIKAWA Mutsumi
2003-04-03 11:28     ` Dave Jones
2003-04-04  7:58   ` Denis Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030402221046.GA30881@suse.de \
    --to=davej@codemonkey.org.uk \
    --cc=fendrakyn@europaguild.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.