From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Sebastian Reichel" <sre@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] power: supply: core: simplify charge_behaviour formatting
Date: Sun, 31 Mar 2024 00:01:39 +0100 [thread overview]
Message-ID: <171183969971.480547.16599196216072730255.b4-ty@collabora.com> (raw)
In-Reply-To: <20240329-power-supply-simplify-v1-1-416f1002739f@weissschuh.net>
On Fri, 29 Mar 2024 09:18:29 +0100, Thomas Weißschuh wrote:
> The function power_supply_show_charge_behaviour() is not needed and can
> be removed completely.
> Removing the function also saves a spurious read of the property from
> the driver on each call.
>
> The convulted logic was a leftover from an earlier patch revision.
> Some restructuring made this cleanup possible.
>
> [...]
Applied, thanks!
[1/1] power: supply: core: simplify charge_behaviour formatting
commit: 91b623cda43e449a49177ba99b6723f551a4bfbe
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Sebastian Reichel" <sre@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] power: supply: core: simplify charge_behaviour formatting
Date: Sun, 31 Mar 2024 00:01:39 +0100 [thread overview]
Message-ID: <171183969971.480547.16599196216072730255.b4-ty@collabora.com> (raw)
Message-ID: <20240330230139.EDYI1qjE22IWns9qzN-FTXr9BHd2qyXyY1qfucJOz4A@z> (raw)
In-Reply-To: <20240329-power-supply-simplify-v1-1-416f1002739f@weissschuh.net>
On Fri, 29 Mar 2024 09:18:29 +0100, Thomas Weißschuh wrote:
> The function power_supply_show_charge_behaviour() is not needed and can
> be removed completely.
> Removing the function also saves a spurious read of the property from
> the driver on each call.
>
> The convulted logic was a leftover from an earlier patch revision.
> Some restructuring made this cleanup possible.
>
> [...]
Applied, thanks!
[1/1] power: supply: core: simplify charge_behaviour formatting
commit: 91b623cda43e449a49177ba99b6723f551a4bfbe
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
next prev parent reply other threads:[~2024-03-30 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 8:18 [PATCH] power: supply: core: simplify charge_behaviour formatting Thomas Weißschuh
2024-03-29 11:32 ` Hans de Goede
2024-03-30 23:01 ` Sebastian Reichel [this message]
2024-03-30 23:01 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171183969971.480547.16599196216072730255.b4-ty@collabora.com \
--to=sebastian.reichel@collabora.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.