All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] common.h: remove error()
Date: Wed, 13 Sep 2017 20:45:03 +0900	[thread overview]
Message-ID: <1505303106-9780-4-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1505303106-9780-1-git-send-email-yamada.masahiro@socionext.com>

This macro has prevented us from using compiletime_error/assert
in <linux/compiler.h>.

Now we can remove it, then we will be able to import more BUILD_BUG
macros from Linux.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 include/common.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/common.h b/include/common.h
index ae3b876..e66b8ff 100644
--- a/include/common.h
+++ b/include/common.h
@@ -89,11 +89,6 @@ void __assert_fail(const char *assertion, const char *file, unsigned line,
 	({ if (!(x) && _DEBUG) \
 		__assert_fail(#x, __FILE__, __LINE__, __func__); })
 
-#define error(fmt, args...) do {					\
-		printf("ERROR: " pr_fmt(fmt) "\nat %s:%d/%s()\n",	\
-			##args, __FILE__, __LINE__, __func__);		\
-} while (0)
-
 #ifndef BUG
 #define BUG() do { \
 	printf("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __FUNCTION__); \
-- 
2.7.4

  parent reply	other threads:[~2017-09-13 11:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 11:45 [U-Boot] [PATCH 0/6] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada
2017-09-13 11:45 ` [U-Boot] [PATCH 1/6] printk: collect printk stuff into <linux/printk.h> Masahiro Yamada
2017-09-13 11:45 ` [U-Boot] [PATCH 2/6] treewide: replace with error() with pr_err() Masahiro Yamada
2017-09-17 17:52   ` Simon Glass
2017-09-13 11:45 ` Masahiro Yamada [this message]
2017-09-13 11:45 ` [U-Boot] [PATCH 4/6] vsprintf.h: include <linux/types.h> Masahiro Yamada
2017-09-13 11:45 ` [U-Boot] [PATCH 5/6] bug.h: sync BUILD_BUG stuff with Linux 4.13 Masahiro Yamada
2017-09-13 11:45 ` [U-Boot] [PATCH 6/6] bug.h: move runtime BUG/WARN macros into <linux/bug.h> Masahiro Yamada
2017-09-14  2:08 ` [U-Boot] [PATCH 0/6] Sync and consolidate Linux-derived printk, BUILD_BUG, BUG, WARN, etc Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505303106-9780-4-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.