| Date | Commit message (Collapse) |
|---|
|
soxi or ffprobe may infinite loop on bad files, so be sure to
let these processes timeout properly.
|
|
.exitstatus alone won't tell you about the signal received.
|
|
As with soxi(1), waiting for ffprobe(1) or avprobe(1) is still
an expensive operation despite Process.spawn being optimized to
use vfork(2).
|
|
As with sox, these will be dealing with legacy encodings
and badly-encoding software until the end of days, so do
our best to fix them up.
|
|
When this project started avconv was favored in Debian,
but that hasn't been the case in many years. Increase
the priority of ffmpeg to match the current situation in
Debian.
|
|
ffprobe aways says `track' instead of `TRACKNUMBER'; but
the rest of our code follows FLAC metadata conventions;
so use `TRACKNUMBER'.
(avprobe is untested since the libav project is dead)
|
|
We use DTAS.yaml_load to wrap all YAML.*load calls, but
we still need "require 'yaml'" for various .to_yaml calls.
|
|
This ought to save some memory for dtas-player and
dtas-readahead users with multiple instances of the same
track(s) on their track list.
|
|
Psych 4.x defaults to "nanny mode" to handle untrusted data.
This causes breakage with since YAML references (aliases)
emitted by dtas-player can't be handled by Psych clients under
Ruby 3.1. Since dtas is single user and is a shell designed to
run arbitrary code, favor the new YAML.unsafe_load API which
behaves like the old YAML.load in Ruby <= 3.0.
|
|
Ruby 2.3+ supports String#@-, though it did not deduplicate
strings. But 2.5 is already old at this point and most users
can be expected to have it.
This gives some memory regressions for Ruby <= 2.4 users,
but cuts down on the code we maintain and reduces bytecode
overhead for 2.5+ users.
|
|
This allows dtas-player to play files with wonky filenames
when piping ffmpeg (or avconv) to sox. SoX-only code
dtas-player paths are not affected since they don't require
an extra Bourne shell.
All of our internal shell pipelines quote "$INFILE",
anyways, so there was never any need to escape for those.
This may cause compatibility problems for splitfx users, but
splitfx is probably too esoteric to have any users besides
myself. And I expect anybody editing audio with dtas-splitfx to
pick shell-friendly filenames.
dtas-player is far more general, and likely to encounter
shell-unfriendly filenames which require quoting.
|
|
Using the 'update-copyright' script from gnulib[1]:
git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
UPDATE_COPYRIGHT_USE_INTERVALS=2 \
xargs /path/to/gnulib/build-aux/update-copyright
[1] https://git.savannah.gnu.org/git/gnulib.git
|
|
A bunch of minor fixes and cleanups accumulating for the past
two years since the last release. It's tough to remember to
make releases when I'm always running the latest version from
git :x
Most notably, "io_splice" is no longer used for dtas-linux
users since "sleepy_penguin" includes all the functionality
we use. This is to reduce memory overhead from extra DSOs(*)
There's also some deprecation warning fixes for the
still-undocumented "dtas-mlib" command.
12 changes since v0.15.0 (2017-04-07):
pipeline: new module for running process pipelines
console: ensure time calculations are done in UTC
Rakefile: update path for uploads
player: support guessing encodings for comments
get rid of Windows-31J regexps
mlib: compatibility with Sequel 5.x
mlib: remove redundant tag massaging and encoding
mlib: use flock to get around SQLite busy errors
mlib: ignore files with nil times
dtas/watchable: check SystemCallError
mlib: fix unused variable warning
use sleepy_penguin 3.5+ for splice and tee support
(*) https://udrepper.livejournal.com/8790.html
|
|
This can be helpful for end users and is close to what other
players use. We can fallback to Encoding.default_external by
default (typically UTF-8) and then again using `charlock_holmes'
if installed.
Note: path names remain binary, because that's how proper
filesystems operate.
|
|
This is faster than relying on eval() for older Rubies.
https://bugs.ruby-lang.org/issues/13077
Ruby 2.5 is targetted for release in December 2017.
|
|
This is needed for the "ALBUM ARTIST" tag which has a space in
the name. This is looser than
<http://www.xiph.org/vorbis/doc/v-comment.html>, but probably
good enough for practical purposes.
|
|
One normal method dispatch is probably preferable to two
optimized instructions + immediate.
|
|
HTTPS allows some level of security(*) and we've actually
supported it on 80x24.org for many months, now. So, point new
readers to it.
Moving away from hostname-based homepages will allow us to save
on subjectAltName space (and bandwith) when negotiating an HTTPS
connection. We'll also have an .onion mirror for Tor users,
soon, too; in case we can't afford to pay ICANN in the future.
(assuming TLS libraries don't have any more Heartblead-level
bugs in them, CAs aren't compromised, MITM HTTPS stripping
proxies don't get in your way, and your certificate bundle isn't
compromised).
|
|
This should improve performance with slow filesystems
or systems with slow spawn performance.
|
|
Newer avprobe outputs a new format, fix our parser to workaround
this while remaining compatible with the old one in Debian wheezy.
Additionally, ffprobe is no longer available as a link to
avprobe.
|
|
Almost, we will need to get a list of all suffixes supported
by ffprobe or avprobe. This could prove tricky..
|
|
The @last_failed state is in the parent object, not the dup-ed
object we fork off of.
|
|
We load them frequently enough that the garbage
is not worth it.
|
|
This reduces memory usage as a Regexp object is hundreds
of bytes and a single-byte string object is only 40 bytes
that is deduped within the VM.
|
|
It is possible for a file to only have one of the ReplayGain
tags we need and not the previous-required REPLAYGAIN_TRACK_GAIN
tag. So do not reject the entire series of tags if a file has
the one we want.
|
|
Using the 'update-copyright' script from gnulib[1]:
git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
UPDATE_COPYRIGHT_USE_INTERVALS=2 \
xargs /path/to/gnulib/build-aux/update-copyright
[1] git://git.savannah.gnu.org/gnulib.git
|
|
It's easier to leave numerics unquoted in YAML; so automatically
stringify comments comming from the YAML file.
|
|
While we're in the area, make a wording change from "GPLv3 or later"
to "GPL-3.0+", as the latter is favored by SPDX.org
|
|
Since writing nested shell commands inside YAML is subject to all
sorts of strange quoting rules, encourage users to rely on external
scripts which the YAML file refers to instead. These scripts can be
written in any reasonable scripting language capable of executing
other commands.
This allows transparently monitoring things such as `my-script.rb'
in the below example when playing my-splitfx.yml via dtas-player:
--------------------- my-splitfx.yml -----------------------
infile: input.flac
command: $INDIR/my-script.rb "$INFILE"
...
--------------------- my-script.rb --------------------------
#!/usr/bin/ruby
require 'shellwords'
infile = ARGV.shift
ch = %W(sox #{infile} -p).concat((ENV['TRIMFX'] || '').shellsplit)
fx = %W(highpass 25 gain 9)
l = ch.dup.concat(%W(remix 1v1)).concat(fx).concat(%w(contrast 30))
r = ch.dup.concat(%W(remix 2v1)).concat(fx).concat(%w(contrast 0))
cmd = %W(sox -M |#{l.shelljoin} |#{r.shelljoin})
cmd.concat((ENV['SOXFMT'] || '-p').shellsplit)
cmd.concat(%w(- stats))
warn cmd.inspect
exec *cmd
|
|
We may expand them, so ensure they're properly escaped, first
for use in shell snippets.
|
|
For seeking, the name might be a little confusing,
but this is zero relative to the current queued source.
|
|
This feature is intended to allow users to "zoom-in" on a
particular portion of a track to tweak parameters (either
with dtas-sourceedit(1) or via playback of splitfx YAML files).
This may be combined with looping the tracklist
(via "tl repeat").
|
|
Hopefully this makes the code less daunting to newcomers
|
|
The documentation part is managed by the new
Documentation/update-copyright script. For the future, the rest may
be managed by the update-copyright tool in gnulib
|
|
This makes debugging, grepping, and following code confusing
at times and also unexpected breaks usage of the global "spawn"
method.
|
|
This allows changes in the source YAML file to be reflected
immediately in player after the user saves the file in their
favorite $EDITOR. Previously, a user would need to:
1) start dtas-sourceedit, spawning $EDITOR
2) edit the file
3) save changes
4) exit $EDITOR
5) repeat starting from 1) until happy with the results
Now, the workflow allows avoiding the context switch between their
$EDITOR and terminal to restart dtas-sourcedit:
1) start dtas-sourceedit, spawning $EDITOR
2) edit the file
3) save changes
4) repeat starting from 1) until happy with the results
5) exit $EDITOR
In my experience, this greatly speeds up tuning of the playback
change, giving all the repeatability and flexibility of editing text
files while having the immediacy of an interactive UI.
Keep in mind this can cause problems for those with auto-save
enabled in their $EDITOR buffer at inopportune times, so a
-N/--no-watch option is added.
|
|
These are intended to act like `$(@D)' and `$(@F)' in GNU make(1)
and to ease managing temporary files for some effects
(e.g. noiseprof + noisered in sox) for splitfx users.
|
|
We cannot afford to break the entire player because somebody
enqueued a non-existent file (or enqueued and later renamed it).
|
|
While the splitfx source is intended for applying effects to
untracked audio files (e.g. transfers of vinyl records or
live concert recordings), it should be useful for applying
effects to an already-tracked recording.
|
|
This should allow users to setup effects in a more standardized
fashion and avoid needing to specify a "command:" field in their
splitfx YAML files in the general case.
|
|
Since splitfx YAML files are intended to be frequently edited and
modified by the user, we'll support automatically restarting the
source when the user saves changes via their favorite $EDITOR
This change is only for Linux users. However, sleepy_penguin
supports kqueue nowadays so a patch to support such functionality
would be appreciated.
|
|
This allows splitfx users to test CUE breakpoints and run
file-specific effects without interrupting their normal flow.
|
|
I'm still normal, and still trolling, but 80x24.org will be epic :)
|
|
This reduces duplication for sox-based components, which our audio
editing components will rely on. We only use avconv/ffmpeg for odd
formats which sox does not play natively, and editing audio in
strange/lossy formats is undesirable anyways.
|
|
This adds the ability to seek internally within FLAC file
based on the internal CUE sheet. Other formats may be supported
in the future, but FLAC is the only one I know of which supports
embedded cue sheets.
Note: flac 1.3.0 is recommended for users of non-CDDA-compatible
formats.
See updates to dtas-player_protocol(7) for details.
|
|
This will allow users to more-easily edit configs and feel
like a real shell. We no longer mistakenly expand nil env
variables to "" anymore, either.
|
|
Singleton methods tend to be bad like this.
TODO: write tests for this.
|
|
Some containers (e.g. large VOBs) are not easily probed and require
additional options for avprobe/ffprobe to find audio streams. We do
this by looping and increasing the duration/size of the probe to
find new audio streams.
This seems to work reasonably well for some DVD rips I have until
seeking is required. This breaks if the seek point (including seeks
for source effects) exceeds the avprobe/ffprobe -analyzeduration.
Anyways, I recommend extracting the audio stream (without
transcoding) out of the VOB container as the best way to go.
Something like:
avconv -analyzeduration 2G -probesize 2G \
-i input.vob -vn -sn -c:a copy -map 0:$STREAM_NR output.ext
|
|
This is reproducible on a video file with a mono audio stream
when attempting playback in stereo.
|
|
We don't need it since IO#read(bytes, buf) will convert to
ASCII-8BIT anyways. Everywhere else, we ensure path names are
already binary. We do this mainly at the client layer before using
Shellwords to escape the paths.
We also must be careful about parsing output from soxi/avprobe
which can show us metadata in whatever encoding is in the file.
We must still handle data from parsing command output as binary,
as the encoding of file metadata tends to vary.
This also should buy us Syck compatibility for Ruby 1.9.3 users
on Debian systems where Ruby 1.9.3 still uses Syck.
|