From: Eric Wong <e@80x24.org>
To: <dtas-all@nongnu.org>
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] favor recv and recv_nonblock over recvmsg variants
Date: Tue, 16 Jun 2015 00:36:51 +0000 [thread overview]
Message-ID: <1434415011-23055-1-git-send-email-e@80x24.org> (raw)
We never use the full return value of the recvmsg* methods,
so those allocations are wasted.
---
lib/dtas/unix_accepted.rb | 2 +-
lib/dtas/unix_client.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dtas/unix_accepted.rb b/lib/dtas/unix_accepted.rb
index c08d431..a0000cf 100644
--- a/lib/dtas/unix_accepted.rb
+++ b/lib/dtas/unix_accepted.rb
@@ -56,7 +56,7 @@ class DTAS::UNIXAccepted # :nodoc:
begin
begin
- msg, _, _ = io.recvmsg_nonblock(nread, 0, 0)
+ msg = io.recv_nonblock(nread)
rescue Errno::EAGAIN
return :wait_readable
rescue EOFError, SystemCallError
diff --git a/lib/dtas/unix_client.rb b/lib/dtas/unix_client.rb
index fbb1510..2c8ba43 100644
--- a/lib/dtas/unix_client.rb
+++ b/lib/dtas/unix_client.rb
@@ -41,6 +41,6 @@ class DTAS::UNIXClient # :nodoc:
IO.select([@to_io], nil, nil, timeout)
nr = @to_io.nread
nr > 0 or raise EOFError, "unexpected EOF from server"
- @to_io.recvmsg(nr, 0, 0)[0]
+ @to_io.recv(nr)
end
end
--
EW
reply other threads:[~2015-06-16 0:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434415011-23055-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).