* [PATCH] favor recv and recv_nonblock over recvmsg variants
@ 2015-06-16 0:36 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-06-16 0:36 UTC (permalink / raw)
To: dtas-all; +Cc: Eric Wong
We never use the full return value of the recvmsg* methods,
so those allocations are wasted.
---
lib/dtas/unix_accepted.rb | 2 +-
lib/dtas/unix_client.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dtas/unix_accepted.rb b/lib/dtas/unix_accepted.rb
index c08d431..a0000cf 100644
--- a/lib/dtas/unix_accepted.rb
+++ b/lib/dtas/unix_accepted.rb
@@ -56,7 +56,7 @@ class DTAS::UNIXAccepted # :nodoc:
begin
begin
- msg, _, _ = io.recvmsg_nonblock(nread, 0, 0)
+ msg = io.recv_nonblock(nread)
rescue Errno::EAGAIN
return :wait_readable
rescue EOFError, SystemCallError
diff --git a/lib/dtas/unix_client.rb b/lib/dtas/unix_client.rb
index fbb1510..2c8ba43 100644
--- a/lib/dtas/unix_client.rb
+++ b/lib/dtas/unix_client.rb
@@ -41,6 +41,6 @@ class DTAS::UNIXClient # :nodoc:
IO.select([@to_io], nil, nil, timeout)
nr = @to_io.nread
nr > 0 or raise EOFError, "unexpected EOF from server"
- @to_io.recvmsg(nr, 0, 0)[0]
+ @to_io.recv(nr)
end
end
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-16 0:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-16 0:36 [PATCH] favor recv and recv_nonblock over recvmsg variants Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).