about summary refs log tree commit
path: root/ui-commit.c
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2014-01-13 03:56:50 +0100
committerJason A. Donenfeld <Jason@zx2c4.com>2014-01-14 02:00:07 +0100
commit800380dde797ae35d738a644acdae2fabb9a0d44 (patch)
tree4770bb2a3eb10021f5d527200ad61a2659a78bea /ui-commit.c
parentf43b228d0bca5791be98ff3fbb2f8743219635b6 (diff)
downloadcgit-800380dde797ae35d738a644acdae2fabb9a0d44.tar.gz
filter: return on null filter from open and close
So that we don't have to include the if(filter) open_filter(filter)
block everywhere, we introduce the guard in the function itself. This
should simplify quite a bit of code.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'ui-commit.c')
-rw-r--r--ui-commit.c18
1 files changed, 6 insertions, 12 deletions
diff --git a/ui-commit.c b/ui-commit.c
index aa1892f..5ac79c0 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -107,28 +107,22 @@ void cgit_print_commit(char *hex, const char *prefix)
         }
         html("</table>\n");
         html("<div class='commit-subject'>");
-        if (ctx.repo->commit_filter)
-                cgit_open_filter(ctx.repo->commit_filter);
+        cgit_open_filter(ctx.repo->commit_filter);
         html_txt(info->subject);
-        if (ctx.repo->commit_filter)
-                cgit_close_filter(ctx.repo->commit_filter);
+        cgit_close_filter(ctx.repo->commit_filter);
         show_commit_decorations(commit);
         html("</div>");
         html("<div class='commit-msg'>");
-        if (ctx.repo->commit_filter)
-                cgit_open_filter(ctx.repo->commit_filter);
+        cgit_open_filter(ctx.repo->commit_filter);
         html_txt(info->msg);
-        if (ctx.repo->commit_filter)
-                cgit_close_filter(ctx.repo->commit_filter);
+        cgit_close_filter(ctx.repo->commit_filter);
         html("</div>");
         if (notes.len != 0) {
                 html("<div class='notes-header'>Notes</div>");
                 html("<div class='notes'>");
-                if (ctx.repo->commit_filter)
-                        cgit_open_filter(ctx.repo->commit_filter);
+                cgit_open_filter(ctx.repo->commit_filter);
                 html_txt(notes.buf);
-                if (ctx.repo->commit_filter)
-                        cgit_close_filter(ctx.repo->commit_filter);
+                cgit_close_filter(ctx.repo->commit_filter);
                 html("</div>");
                 html("<div class='notes-footer'></div>");
         }