From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 12/18] viewvcs: psgi_yield
Date: Mon, 23 Oct 2023 08:48:31 +0000 [thread overview]
Message-ID: <20231023084837.2804687-12-e@80x24.org> (raw)
In-Reply-To: <20231023084837.2804687-1-e@80x24.org>
Another drop-in replacement, though I took the opportunity
to avoid unnecessarily bumping the refcount of $ctx->{env}
---
lib/PublicInbox/ViewVCS.pm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 86c46e69..6c588ddf 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -101,9 +101,8 @@ sub stream_large_blob ($$) {
my ($git, $oid, $type, $size, $di) = @$res;
my $cmd = ['git', "--git-dir=$git->{git_dir}", 'cat-file', $type, $oid];
my $qsp = PublicInbox::Qspawn->new($cmd);
- my $env = $ctx->{env};
- $env->{'qspawn.wcb'} = $ctx->{-wcb};
- $qsp->psgi_return($env, undef, \&stream_blob_parse_hdr, $ctx);
+ $ctx->{env}->{'qspawn.wcb'} = $ctx->{-wcb};
+ $qsp->psgi_yield($ctx->{env}, undef, \&stream_blob_parse_hdr, $ctx);
}
sub show_other_result ($$) { # future-proofing
@@ -341,7 +340,7 @@ sub show_patch ($$) {
my $qsp = PublicInbox::Qspawn->new(\@cmd);
$ctx->{env}->{'qspawn.wcb'} = $ctx->{-wcb};
$ctx->{patch_oid} = $oid;
- $qsp->psgi_return($ctx->{env}, undef, \&stream_patch_parse_hdr, $ctx);
+ $qsp->psgi_yield($ctx->{env}, undef, \&stream_patch_parse_hdr, $ctx);
}
sub show_commit ($$) {
next prev parent reply other threads:[~2023-10-23 8:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 8:48 [PATCH 01/18] limiter: split out from qspawn Eric Wong
2023-10-23 8:48 ` [PATCH 02/18] spawn: support synchronous run_qx Eric Wong
2023-10-23 8:48 ` [PATCH 03/18] psgi_qx: use a temporary file rather than pipe Eric Wong
2023-10-23 8:48 ` [PATCH 04/18] www_coderepo: capture uses a flattened list Eric Wong
2023-10-23 8:48 ` [PATCH 05/18] qspawn: psgi_return allows list for callback args Eric Wong
2023-10-23 8:48 ` [PATCH 06/18] qspawn: drop unused err arg for ->event_step Eric Wong
2023-10-23 8:48 ` [PATCH 07/18] httpd/async: require IO arg Eric Wong
2023-10-23 8:48 ` [PATCH 08/18] xt/check-run: call DS->Reset after all tests Eric Wong
2023-10-23 8:48 ` [PATCH 09/18] qspawn: introduce new psgi_yield API Eric Wong
2023-10-23 8:48 ` [PATCH 10/18] repo_atom: switch to psgi_yield Eric Wong
2023-10-23 8:48 ` [PATCH 11/18] repo_snapshot: psgi_yield Eric Wong
2023-10-23 8:48 ` Eric Wong [this message]
2023-10-23 8:48 ` [PATCH 13/18] www_altid: switch to psgi_yield Eric Wong
2023-10-23 8:48 ` [PATCH 14/18] cgit: " Eric Wong
2023-10-23 8:48 ` [PATCH 15/18] www_coderepo: psgi_yield Eric Wong
2023-10-23 8:48 ` [PATCH 16/18] drop psgi_return, httpd/async and GetlineBody Eric Wong
2023-10-23 8:48 ` [PATCH 17/18] qspawn: use WwwStatic for fallbacks and error code Eric Wong
2023-10-23 8:48 ` [PATCH 18/18] qspawn: simplify argument passing Eric Wong
-- strict thread matches above, loose matches on Subject: below --
2023-10-19 12:40 [PATCH 01/18] limiter: split out from qspawn Eric Wong
2023-10-19 12:40 ` [PATCH 12/18] viewvcs: psgi_yield Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023084837.2804687-12-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).