dumping ground for random patches and texts
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 11/14] blocking mjit_finish
Date: Tue, 26 Jun 2018 09:38:14 +0000	[thread overview]
Message-ID: <20180626093817.1533-12-e@80x24.org> (raw)
In-Reply-To: <20180626093817.1533-1-e@80x24.org>

---
 mjit.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/mjit.c b/mjit.c
index 603b192c27..60b544e15e 100644
--- a/mjit.c
+++ b/mjit.c
@@ -1556,22 +1556,6 @@ mjit_resume(void)
     return Qtrue;
 }
 
-static void *
-wait_pch(void *ignored)
-{
-    rb_native_cond_wait(&mjit_pch_wakeup, &mjit_engine_mutex);
-    return 0;
-}
-
-static void
-ubf_pch(void *ignored)
-{
-    if (pthread_mutex_trylock(&mjit_engine_mutex) == 0) {
-        rb_native_cond_signal(&mjit_pch_wakeup);
-        rb_native_mutex_unlock(&mjit_engine_mutex);
-    }
-}
-
 /* Finish the threads processing units and creating PCH, finalize
    and free MJIT data.  It should be called last during MJIT
    life.  */
@@ -1592,7 +1576,7 @@ mjit_finish(void)
     while (pch_status == PCH_NOT_READY) {
         verbose(3, "Waiting wakeup from make_pch");
         /* release GVL to handle interrupts */
-        rb_thread_call_without_gvl(wait_pch, 0, ubf_pch, 0);
+        rb_native_cond_wait(&mjit_pch_wakeup, &mjit_engine_mutex);
     }
     CRITICAL_SECTION_FINISH(3, "in mjit_finish to wakeup from pch");
 
-- 
EW


  parent reply	other threads:[~2018-06-26  9:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26  9:38 [PATCH 00/14] SIGCHLD hijack for waitpid Eric Wong
2018-06-26  9:38 ` [PATCH 01/14] hijack SIGCHLD handler for internal use Eric Wong
2018-06-26  9:38 ` [PATCH 02/14] fix SIGCHLD hijacking race conditions Eric Wong
2018-06-26  9:38 ` [PATCH 03/14] mjit.c: allow working on platforms without SIGCHLD Eric Wong
2018-06-26  9:38 ` [PATCH 04/14] cleanups Eric Wong
2018-06-26  9:38 ` [PATCH 05/14] handle SIGCHLD in both the timer-thread and main thread Eric Wong
2018-06-26  9:38 ` [PATCH 06/14] Revert "test_process.rb: skip tests for Bug 14867" Eric Wong
2018-06-26  9:38 ` [PATCH 07/14] Revert "spec: skip Process wait specs on MJIT" Eric Wong
2018-06-26  9:38 ` [PATCH 08/14] wip testing Eric Wong
2018-06-26  9:38 ` [PATCH 09/14] pgrp list Eric Wong
2018-06-26  9:38 ` [PATCH 10/14] grantpt Eric Wong
2018-06-26  9:38 ` Eric Wong [this message]
2018-06-26  9:38 ` [PATCH 12/14] reinitialize waitpid_lock Eric Wong
2018-06-26  9:38 ` [PATCH 13/14] signal.c: prevent spurious wakeup of main thread for SIGCHLD Eric Wong
2018-06-26  9:38 ` [PATCH 14/14] process.c (rb_waitpid): reimplement non-SIGCHLD code path Eric Wong
2018-06-26 10:51 ` [PATCH 15/14] force SIGCHLD to the timer-thread Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180626093817.1533-12-e@80x24.org \
    --to=e@80x24.org \
    --cc=spew@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).