From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 5/4] thread_sync.c (mutex_lock): add missing else
Date: Wed, 2 May 2018 04:42:55 +0000 [thread overview]
Message-ID: <20180502044255.GA30679@80x24.org> (raw)
In-Reply-To: <20180501080844.22751-5-e@80x24.org>
We do not want to trigger GC if we successfully acquire mutex.
[ruby-core:86816]
---
Will squash
thread_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/thread_sync.c b/thread_sync.c
index 86a102151ef..3eb570857e9 100644
--- a/thread_sync.c
+++ b/thread_sync.c
@@ -297,7 +297,7 @@ rb_mutex_lock(VALUE self)
if (mutex->th == th) {
mutex_locked(th, self);
}
- if (do_gc) {
+ else if (do_gc) {
/*
* Likely no point in checking for GVL contention here
* this Mutex is already contended and we just yielded
--
EW
next prev parent reply other threads:[~2018-05-02 4:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 8:08 [WIP v2 0/4] sleepy GC Eric Wong
2018-05-01 8:08 ` [WIP v2 1/4] thread.c (timeout_prepare): common function Eric Wong
2018-05-01 8:08 ` [WIP v2 2/4] gc: rb_wait_for_single_fd performs GC if idle (Linux) Eric Wong
2018-05-01 8:08 ` [WIP v2 3/4] thread.c (do_select): perform GC if idle Eric Wong
2018-05-01 8:08 ` [WIP v2 4/4] thread.c: native_sleep callers may perform GC Eric Wong
2018-05-02 4:42 ` Eric Wong [this message]
2018-05-02 4:52 ` [PATCH 6/4] gc.c: allow disabling sleepy GC Eric Wong
2018-05-02 4:57 ` [PATCH] benchmark: add benchmarks for " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502044255.GA30679@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).