From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 1/4] thread.c (rb_thread_terminate_all): eliminate double2timeval call
Date: Fri, 2 Feb 2018 05:18:34 +0000 [thread overview]
Message-ID: <20180202051837.14192-2-e@80x24.org> (raw)
In-Reply-To: <20180202051837.14192-1-e@80x24.org>
No point for a fixed 1s value, and I plan on eliminating double
timeouts from internal API.
---
thread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/thread.c b/thread.c
index 23957eba09..fe5386a95d 100644
--- a/thread.c
+++ b/thread.c
@@ -506,7 +506,7 @@ rb_thread_terminate_all(void)
terminate_all(vm, th);
while (vm_living_thread_num(vm) > 1) {
- struct timeval tv = double2timeval(1.0);
+ struct timeval tv = { 1, 0 };
/*
* Thread exiting routine in thread_start_func_2 notify
* me when the last sub-thread exit.
--
EW
next prev parent reply other threads:[~2018-02-02 5:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 5:18 [PATCHv2 0/4] remove most FP from thread.c Eric Wong
2018-02-02 5:18 ` Eric Wong [this message]
2018-02-02 5:18 ` [PATCH 2/4] thread.c: extract timeval_sub from timeval_update_expire Eric Wong
2018-02-02 5:18 ` [PATCH 3/4] thread.c: avoid FP for Thread#join Eric Wong
2018-02-02 5:18 ` [PATCH 4/4] thread.c: avoid FP in C-API time calculations Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202051837.14192-2-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).