From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 4/6] webrick: WEBrick::Log requires path arg when given string
Date: Thu, 21 Dec 2017 11:55:05 +0000 [thread overview]
Message-ID: <20171221115507.27500-5-e@80x24.org> (raw)
In-Reply-To: <20171221115507.27500-1-e@80x24.org>
Allowing a user to specify "| command" via Kernel#open is
nonsensical since we never read from the resultant IO.
* lib/webrick/log.rb (initialize): replace Kernel#open with File.open
---
lib/webrick/log.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/webrick/log.rb b/lib/webrick/log.rb
index 41e907cd3b..2c1fdfe602 100644
--- a/lib/webrick/log.rb
+++ b/lib/webrick/log.rb
@@ -51,7 +51,7 @@ def initialize(log_file=nil, level=nil)
@level = level || INFO
case log_file
when String
- @log = open(log_file, "a+")
+ @log = File.open(log_file, "a+")
@log.sync = true
@opened = true
when NilClass
--
EW
next prev parent reply other threads:[~2017-12-21 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 11:55 [PATCH 0/6] webrick: audit and fix Kernel#open misuse Eric Wong
2017-12-21 11:55 ` [PATCH 1/6] webrick: httpauth requires regular files Eric Wong
2017-12-21 11:55 ` [PATCH 2/6] webrick/httpservlet/cgi_runner.rb: remove unnecessary open Eric Wong
2017-12-21 11:55 ` [PATCH 3/6] webrick: add test for WEBrick::HTTPServlet::ERBHandler Eric Wong
2017-12-21 11:55 ` Eric Wong [this message]
2017-12-21 11:55 ` [PATCH 5/6] webrick/httpservlet/*handler: use File.open Eric Wong
2017-12-21 11:55 ` [PATCH 6/6] webrick/httputils: note Kernel#open behavior Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221115507.27500-5-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).