From: Eric Wong <yahns-public@yhbt.net>
To: spew@80x24.org
Subject: [PATCH] USR2 upgrades may use Process.spawn for vfork
Date: Fri, 24 Mar 2017 22:29:07 +0000 [thread overview]
Message-ID: <20170324222907.13961-1-yahns-public@yhbt.net> (raw)
Remove false statements about close-on-exec being cleared in the
parent process (verified via strace) and refactor the code to
take full advantage of options for Process.spawn and Process.exec.
This avoids unnecessary CoW traffic for the common case where
before_exec is unset.
---
lib/yahns/server.rb | 33 ++++++++++++++++-----------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/lib/yahns/server.rb b/lib/yahns/server.rb
index 861b919..43caae6 100644
--- a/lib/yahns/server.rb
+++ b/lib/yahns/server.rb
@@ -237,24 +237,23 @@ def reexec
end
end
- # We cannot use Process.spawn here because of redirects + close-on-exec
- # We must keep close_on_exec=true in the parent process and only set
- # close_on_exec=false in the child. There must be no opportunity
- # for the user app to ever get a listen socket with close_on_exec=false
- @reexec_pid = fork do
- redirects = {}
- @listeners.each do |sock|
- sock.close_on_exec = false
- redirects[sock.fileno] = sock
+ opt = {}
+ @listeners.each { |sock| opt[sock.fileno] = sock }
+ env = ENV.to_hash
+ env['YAHNS_FD'] = opt.keys.join(',')
+ opt[:close_others] = true
+ cmd = [ Yahns::START[0] ].concat(Yahns::START[:argv])
+ dir = @config.value(:working_directory) || Yahns::START[:cwd]
+ @logger.info "spawning #{cmd.inspect} (in #{dir})"
+ @reexec_pid = if @before_exec
+ fork do
+ Dir.chdir(dir)
+ @before_exec.call(cmd)
+ exec(env, *cmd, opt)
end
- ENV['YAHNS_FD'] = redirects.keys.join(',')
- redirects[:close_others] = true
- Dir.chdir(@config.value(:working_directory) || Yahns::START[:cwd])
- cmd = [ Yahns::START[0] ].concat(Yahns::START[:argv])
- @logger.info "executing #{cmd.inspect} (in #{Dir.pwd})"
- @before_exec.call(cmd) if @before_exec
- cmd << redirects
- exec(*cmd)
+ else
+ opt[:chdir] = dir
+ spawn(env, *cmd, opt)
end
end
--
EW
reply other threads:[~2017-03-24 22:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324222907.13961-1-yahns-public@yhbt.net \
--to=yahns-public@yhbt.net \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).