From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31078 217.115.0.0/20 X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,RCVD_IN_XBL,SPF_FAIL, SPF_HELO_FAIL,TO_EQ_FM_DOM_SPF_FAIL shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from 80x24.org (tor1.anonymizer.ccc.de [217.115.10.131]) by dcvr.yhbt.net (Postfix) with ESMTP id 7CA7420314 for ; Thu, 9 Mar 2017 03:47:44 +0000 (UTC) From: Eric Wong To: spew@80x24.org Subject: [PATCH] ext/socket/raddrinfo.c (addrinfo_mark): avoid needless branch Date: Thu, 9 Mar 2017 03:47:41 +0000 Message-Id: <20170309034741.8020-1-e@80x24.org> List-Id: gc.c (gc_mark_children, case T_DATA) does not use the dmark function pointer if DATA_PTR is NULL --- ext/socket/raddrinfo.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ext/socket/raddrinfo.c b/ext/socket/raddrinfo.c index 67bc9c2a97..dcabb2022e 100644 --- a/ext/socket/raddrinfo.c +++ b/ext/socket/raddrinfo.c @@ -726,10 +726,8 @@ static void addrinfo_mark(void *ptr) { rb_addrinfo_t *rai = ptr; - if (rai) { - rb_gc_mark(rai->inspectname); - rb_gc_mark(rai->canonname); - } + rb_gc_mark(rai->inspectname); + rb_gc_mark(rai->canonname); } #define addrinfo_free RUBY_TYPED_DEFAULT_FREE -- EW