From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 5/6] search: match quote detection behavior of view
Date: Thu, 8 Sep 2016 01:53:09 +0000 [thread overview]
Message-ID: <20160908015310.28670-5-e@80x24.org> (raw)
In-Reply-To: <20160908015310.28670-1-e@80x24.org>
This is stricter than the mutt quote_regexp default
("^([ \t]*[|>:}#])+" on Debian jessie),
but matches what we have in View.pm.
I prefer the stricter quote detection since it is less ambiguous
and less likely to hide/obscure important details.
---
lib/PublicInbox/SearchIdx.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index ae89060..25452da 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -184,7 +184,7 @@ sub add_message {
$part->body_set('');
my @lines = split(/\n/, $body);
while (defined(my $l = shift @lines)) {
- if ($l =~ /^\s*>/) {
+ if ($l =~ /^>/) {
push @quot, $l;
} else {
push @orig, $l;
--
EW
next prev parent reply other threads:[~2016-09-08 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 1:53 [PATCH 1/6] search: allow searching user fields (To/Cc/From) Eric Wong
2016-09-08 1:53 ` [PATCH 2/6] search: drop longer subject: prefix for search Eric Wong
2016-09-08 1:53 ` [PATCH 3/6] search: more granular message body searching Eric Wong
2016-09-08 1:53 ` [PATCH 4/6] search: fix space regressions from recent changes Eric Wong
2016-09-08 1:53 ` Eric Wong [this message]
2016-09-08 1:53 ` [PATCH 6/6] search: increase term positions for each quoted hunk Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908015310.28670-5-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).