dumping ground for random patches and texts
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 06/11] view: allow for missing In-Reply-To mapping
Date: Sun, 14 Aug 2016 10:21:12 +0000	[thread overview]
Message-ID: <20160814102117.11456-6-e@80x24.org> (raw)
In-Reply-To: <20160814102117.11456-1-e@80x24.org>

Because buggy mail clients exist and generate invalid
In-Reply-To headers we cannot handle across the board...
---
 lib/PublicInbox/View.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 5b352d1..3f25028 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -207,8 +207,8 @@ sub _th_index_lite {
 	my $nr_s = 0;
 	my $level = $map->[4];
 	my $idx = $map->[3];
-	if (defined $irt) {
-		my $irt_map = $mapping->{$irt};
+	my $irt_map = $mapping->{$irt} if defined $irt;
+	if (defined $irt_map) {
 		my $siblings = $irt_map->[0];
 		$nr_s = scalar(@$siblings) - 1;
 		$rv .= $pad . $irt_map->[1];
-- 
EW


  parent reply	other threads:[~2016-08-14 10:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-14 10:21 [PATCH 01/11] import_slrnspool: reimplement using fast-import Eric Wong
2016-08-14 10:21 ` [PATCH 02/11] searchidx: do not release Xapian lock while (only) Msgmap is indexing Eric Wong
2016-08-14 10:21 ` [PATCH 03/11] www: do not unecessarily escape some chars in paths Eric Wong
2016-08-14 10:21 ` [PATCH 04/11] www: do not double-clean Message-IDs from internal DBs Eric Wong
2016-08-14 10:21 ` [PATCH 05/11] mid: no wide characters for sha1_hex Eric Wong
2016-08-14 10:21 ` Eric Wong [this message]
2016-08-14 10:21 ` [PATCH 07/11] view: remove redundant pre closing tag Eric Wong
2016-08-14 10:21 ` [PATCH 08/11] squash Eric Wong
2016-08-14 10:21 ` [PATCH 09/11] search: lookup_message may fail Eric Wong
2016-08-14 10:21 ` [PATCH 10/11] searchview: MID fixup SQUASH Eric Wong
2016-08-14 10:21 ` [PATCH 11/11] XML val checks Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160814102117.11456-6-e@80x24.org \
    --to=e@80x24.org \
    --cc=spew@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).