From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS60392 185.128.40.0/24
X-Spam-Status: No, score=0.6 required=3.0 tests=BAYES_00,RCVD_IN_MSPIKE_BL,
	RCVD_IN_MSPIKE_ZBI,RCVD_IN_XBL,RDNS_NONE,SPF_FAIL,SPF_HELO_FAIL,
	TO_EQ_FM_DOM_SPF_FAIL shortcircuit=no autolearn=no autolearn_force=no
	version=3.4.0
Received: from 80x24.org (unknown [185.128.40.220])
	by dcvr.yhbt.net (Postfix) with ESMTP id C34782018E
	for <spew@80x24.org>; Mon,  8 Aug 2016 21:27:55 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 1/3] searchidx: remove unused $git parameters
Date: Mon,  8 Aug 2016 21:27:49 +0000
Message-Id: <20160808212751.27747-1-e@80x24.org>
List-Id: <spew@80x24.org>

We do not need to pass the PublicInbox::Git object to
various callbacks.
---
 lib/PublicInbox/SearchIdx.pm | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index a69428a..9a462c7 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -283,48 +283,48 @@ sub link_message {
 }
 
 sub index_blob {
-	my ($self, $git, $mime, $bytes, $num, $blob) = @_;
+	my ($self, $mime, $bytes, $num, $blob) = @_;
 	$self->add_message($mime, $bytes, $num, $blob);
 }
 
 sub unindex_blob {
-	my ($self, $git, $mime) = @_;
+	my ($self, $mime) = @_;
 	my $mid = eval { mid_clean(mid_mime($mime)) };
 	$self->remove_message($mid) if defined $mid;
 }
 
 sub index_mm {
-	my ($self, $git, $mime) = @_;
+	my ($self, $mime) = @_;
 	$self->{mm}->mid_insert(mid_clean(mid_mime($mime)));
 }
 
 sub unindex_mm {
-	my ($self, $git, $mime) = @_;
+	my ($self, $mime) = @_;
 	$self->{mm}->mid_delete(mid_clean(mid_mime($mime)));
 }
 
 sub index_mm2 {
-	my ($self, $git, $mime, $bytes, $blob) = @_;
+	my ($self, $mime, $bytes, $blob) = @_;
 	my $num = $self->{mm}->num_for(mid_clean(mid_mime($mime)));
-	index_blob($self, $git, $mime, $bytes, $num, $blob);
+	index_blob($self, $mime, $bytes, $num, $blob);
 }
 
 sub unindex_mm2 {
-	my ($self, $git, $mime) = @_;
+	my ($self, $mime) = @_;
 	$self->{mm}->mid_delete(mid_clean(mid_mime($mime)));
-	unindex_blob($self, $git, $mime);
+	unindex_blob($self, $mime);
 }
 
 sub index_both {
-	my ($self, $git, $mime, $bytes, $blob) = @_;
-	my $num = index_mm($self, $git, $mime);
-	index_blob($self, $git, $mime, $bytes, $num, $blob);
+	my ($self, $mime, $bytes, $blob) = @_;
+	my $num = index_mm($self, $mime);
+	index_blob($self, $mime, $bytes, $num, $blob);
 }
 
 sub unindex_both {
-	my ($self, $git, $mime) = @_;
-	unindex_blob($self, $git, $mime);
-	unindex_mm($self, $git, $mime);
+	my ($self, $mime) = @_;
+	unindex_blob($self, $mime);
+	unindex_mm($self, $mime);
 }
 
 sub do_cat_mail {
@@ -361,11 +361,11 @@ sub rlog {
 		if ($line =~ /$addmsg/o) {
 			my $blob = $1;
 			my $mime = do_cat_mail($git, $blob, \$bytes) or next;
-			$add_cb->($self, $git, $mime, $bytes, $blob);
+			$add_cb->($self, $mime, $bytes, $blob);
 		} elsif ($line =~ /$delmsg/o) {
 			my $blob = $1;
 			my $mime = do_cat_mail($git, $blob) or next;
-			$del_cb->($self, $git, $mime);
+			$del_cb->($self, $mime);
 		} elsif ($line =~ /^commit ($h40)/o) {
 			if (defined $max && --$max <= 0) {
 				$max = $self->{batch_size};
-- 
EW