From c6a8fdf71e2c336f6e591c6f4005c8e922c8f2df Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 10 Dec 2016 01:09:50 +0000 Subject: thread: last Reference always wins Since we use SearchMsg from Xapian data, we can be assured we do not get self-referential {references} field. However, we may need to be more careful when checking has_descendent for loops, as blindly calling add_child could open us up to that possibility... --- t/thread-cycle.t | 8 -------- 1 file changed, 8 deletions(-) (limited to 't') diff --git a/t/thread-cycle.t b/t/thread-cycle.t index 0e1ecfe2..b0844490 100644 --- a/t/thread-cycle.t +++ b/t/thread-cycle.t @@ -70,14 +70,6 @@ SKIP: { is($check, $st, 'Mail::Thread output matches'); } -@msgs = map { bless $_, 'PublicInbox::SearchMsg' } ( - { mid => 'a@b' }, - { mid => 'b@c', references => ' ' }, - { mid => 'd@e', references => '' }, -); - -is(thread_to_s(\@msgs), "a\@b\n b\@c\nd\@e\n", 'ok with self-references'); - done_testing(); sub thread_to_s { -- cgit v1.2.3-24-ge0c7