From 6df9454202eeadbdd20af8dd9de5bcceb758b324 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 15 Dec 2023 15:22:45 -0500 Subject: tests: quiet uninitialized warnings on CentOS 7.x Test::More distributed with Perl 5.16.3 on CentOS 7.x expects the `$how_many' argument for `skip' and warns when its uninitialized, so quiet that warning down. --- t/cmd_ipc.t | 4 ++-- t/ds-poll.t | 2 +- t/httpd-corner.t | 2 +- t/lei-convert.t | 2 +- t/lei-daemon.t | 2 +- t/lei-sigpipe.t | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) (limited to 't') diff --git a/t/cmd_ipc.t b/t/cmd_ipc.t index ccf4ca31..08a4dcc3 100644 --- a/t/cmd_ipc.t +++ b/t/cmd_ipc.t @@ -146,9 +146,9 @@ SKIP: { skip 'not Linux', 1 if $^O ne 'linux'; require_ok 'PublicInbox::Syscall'; $send = PublicInbox::Syscall->can('send_cmd4') or - skip 'send_cmd4 not defined for arch'; + skip 'send_cmd4 not defined for arch', 1; $recv = PublicInbox::Syscall->can('recv_cmd4') or - skip 'recv_cmd4 not defined for arch'; + skip 'recv_cmd4 not defined for arch', 1; $do_test->(SOCK_STREAM, 0, 'PP Linux stream'); $do_test->(SOCK_SEQPACKET, 0, 'PP Linux seqpacket'); } diff --git a/t/ds-poll.t b/t/ds-poll.t index 321534bd..22dbc802 100644 --- a/t/ds-poll.t +++ b/t/ds-poll.t @@ -48,7 +48,7 @@ is(scalar @$events, 0, 'nothing ready after EPOLL_CTL_DEL'); is($p->ep_add($r, EPOLLIN), 0, 're-add'); SKIP: { $cls =~ m!::(?:DSPoll|Select)\z! or - skip 'EBADF test for select|poll only'; + skip 'EBADF test for select|poll only', 1; my $old_fd = fileno($r); close $r; my @w; diff --git a/t/httpd-corner.t b/t/httpd-corner.t index 35c88600..7539573c 100644 --- a/t/httpd-corner.t +++ b/t/httpd-corner.t @@ -28,7 +28,7 @@ my @zmods = qw(PublicInbox::GzipFilter IO::Uncompress::Gunzip); # using socket activation: my ($defer_accept_val, $accf_arg, $TCP_DEFER_ACCEPT); SKIP: { - skip 'TCP_DEFER_ACCEPT is Linux-only' if $^O ne 'linux'; + skip 'TCP_DEFER_ACCEPT is Linux-only', 1 if $^O ne 'linux'; $TCP_DEFER_ACCEPT = eval { Socket::TCP_DEFER_ACCEPT() } // 9; setsockopt($sock, IPPROTO_TCP, $TCP_DEFER_ACCEPT, 5); my $x = getsockopt($sock, IPPROTO_TCP, $TCP_DEFER_ACCEPT); diff --git a/t/lei-convert.t b/t/lei-convert.t index 6aff80bb..4670e47f 100644 --- a/t/lei-convert.t +++ b/t/lei-convert.t @@ -165,7 +165,7 @@ EOM $ok = $x; last; } - skip 'pigz || gzip do not support --rsyncable' if !$ok; + skip 'pigz || gzip do not support --rsyncable', 1 if !$ok; lei_ok qw(convert --rsyncable), "mboxrd:$d/qp.gz", '-o', "mboxcl2:$d/qp2.gz"; undef $fh; # necessary to make IO::Uncompress::Gunzip happy diff --git a/t/lei-daemon.t b/t/lei-daemon.t index 2be967be..d97e494a 100644 --- a/t/lei-daemon.t +++ b/t/lei-daemon.t @@ -32,7 +32,7 @@ test_lei({ daemon_only => 1 }, sub { SKIP: { skip 'only testing open files on Linux', 1 if $^O ne 'linux'; my $d = "/proc/$pid/fd"; - skip "no $d on Linux" unless -d $d; + skip "no $d on Linux", 1 unless -d $d; my @before = sort(glob("$d/*")); my $addr = pack_sockaddr_un($sock); open my $null, '<', '/dev/null' or BAIL_OUT "/dev/null: $!"; diff --git a/t/lei-sigpipe.t b/t/lei-sigpipe.t index 1aa700e9..72bc6c7d 100644 --- a/t/lei-sigpipe.t +++ b/t/lei-sigpipe.t @@ -11,7 +11,7 @@ use autodie qw(close open pipe seek sysread); use PublicInbox::IO qw(write_file); my $inboxdir = $ENV{GIANT_INBOX_DIR}; SKIP: { - $inboxdir // skip 'GIANT_INBOX_DIR unset to test large results'; + $inboxdir // skip 'GIANT_INBOX_DIR unset to test large results', 1; require PublicInbox::Inbox; my $ibx = PublicInbox::Inbox->new({ name => 'unconfigured-test', -- cgit v1.2.3-24-ge0c7