From 1e7cc8849b56ec96a16fda97921e1612cedc01a3 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 2 Oct 2022 15:11:01 +0000 Subject: viewdiff: fix parts of diff being appended after signature I'm not sure what kind of brain fart introduced this in c1e7a048be9d32cd, but it happened :x. We'll undef the $x variable ASAP to save memory and make future errors like this one more noticeable. Fixes: c1e7a048be9d ("www: viewdiff: fix UTF-8 names inside mbox attachments") --- lib/PublicInbox/ViewDiff.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lib/PublicInbox/ViewDiff.pm') diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index 95bbf2d2..124a723a 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -212,8 +212,9 @@ sub flush_diff ($$) { for my $s (split(/((?:(?:^\+[^\n]*\n)+)| (?:(?:^-[^\n]*\n)+)| (?:^@@ [^\n]+\n))/xsm, $x)) { + undef $x; if (!defined($dctx)) { - print $afh $x; + print $afh $s; } elsif ($s =~ s/\A@@ (\S+) (\S+) @@//) { print $zfh qq(), diff_hunk($dctx, $1, $2), -- cgit v1.2.3-24-ge0c7