From 28ee19c32a1ecf8e22f30e8f9de860695f4fb30c Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 29 Aug 2015 21:30:27 +0000 Subject: avoid length in boolean context Perl does not currently optimize for this. ref (from p5p): http://mid.gmane.org/D5C27970-9176-4C7A-8B99-7D78360E67A2@pobox.com --- lib/PublicInbox/Search.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lib/PublicInbox/Search.pm') diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm index 4362a002..4b3830e2 100644 --- a/lib/PublicInbox/Search.pm +++ b/lib/PublicInbox/Search.pm @@ -251,10 +251,11 @@ sub subject_summary { last if length($new) >= $max; $subj = $new; } - if (length $subj) { + if ($subj ne '') { my $r = scalar @subj ? ' ...' : ''; $subj =~ s/ \z/$r/s; } else { + # subject has one REALLY long word, and NOT spam? wtf @subj = ($l =~ /\A(.{1,72})/); $subj = $subj[0] . ' ...'; } -- cgit v1.2.3-24-ge0c7