From 1ab8dabe04ebba61fd8761dca3d569947cbe20be Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 9 Feb 2017 00:26:52 +0000 Subject: repobrowse: avoid slurping lines "foreach (<$fh>)" in Perl requests lines in array context, so use "while" instead for lazy reading. This follows ba4c50c20b95679580beba1ef290a4281d5285b7 in master ("config: do not slurp lines into memory") --- lib/PublicInbox/RepobrowseBase.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/PublicInbox/RepobrowseBase.pm') diff --git a/lib/PublicInbox/RepobrowseBase.pm b/lib/PublicInbox/RepobrowseBase.pm index caec5ced..44f422df 100644 --- a/lib/PublicInbox/RepobrowseBase.pm +++ b/lib/PublicInbox/RepobrowseBase.pm @@ -24,7 +24,7 @@ sub mime_load { my ($self, $file) = @_; my %rv; open my $fh, '<', $file or return \%rv; - foreach (<$fh>) { + while (<$fh>) { next if /^#/; # no comments my ($type, @ext) = split(/\s+/); -- cgit v1.2.3-24-ge0c7