From 82cef98a1d43e233d8dd1fff1f3759ee716067c7 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 30 Aug 2023 05:10:40 +0000 Subject: Makefile.PL: fix syntax for ASan and valgrind targets Mixing various quoting and escaping rules between shell, make, and Perl got confusing in Makefile.PL :x This hopefully sorts out my confusion. We'll also fix and use TEST_XH_CXX_ONLY=1 to avoid needlessly running the tests on the XS||SWIG implementation when we're checking for memory errors. Fixes: 2312ca26023fcbe3 (makefile: add targets for ASan and valgrind) --- Makefile.PL | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'Makefile.PL') diff --git a/Makefile.PL b/Makefile.PL index 5865a252..d2309336 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -264,12 +264,13 @@ lib/PublicInbox.pm : FORCE VERSION=\$(VERSION) \$(PERL) -w ./version-gen.perl test-asan : pure_all - CXXFLAGS='-O0 -Wall -ggdb3 -fsanitize=address' \ + TEST_XH_CXX_ONLY=1 CXXFLAGS='-O0 -Wall -ggdb3 -fsanitize=address' \\ prove -bvw t/xap_helper.t -VG_OPT = '-v --trace-children=yes --track-fds=yes' -VG_OPT += ' --leak-check=yes --track-origins=yes' +VG_OPT = -v --trace-children=yes --track-fds=yes +VG_OPT += --leak-check=yes --track-origins=yes test-valgrind : pure_all - VALGRIND="valgrind \$\$(VG_OPT)" prove -bvw t/xap_helper.t + TEST_XH_CXX_ONLY=1 VALGRIND="valgrind \$(VG_OPT)" \\ + prove -bvw t/xap_helper.t EOF } -- cgit v1.2.3-24-ge0c7