From f375ce494db8ce0e28676c89ed8b9d09a16de505 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 28 Jan 2023 11:02:52 +0000 Subject: www_coderepo: reduce utf8::decode calls It's safe to call utf8::decode on data where "\0" exists. --- lib/PublicInbox/WwwCoderepo.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/PublicInbox/WwwCoderepo.pm b/lib/PublicInbox/WwwCoderepo.pm index 4d8713b4..8df6116a 100644 --- a/lib/PublicInbox/WwwCoderepo.pm +++ b/lib/PublicInbox/WwwCoderepo.pm @@ -124,7 +124,6 @@ EOM $last = pop(@r) if scalar(@r) > $ctx->{wcr}->{summary_branches}; for (@r) { my ($pfx, $oid, $ref, $s, $cd) = split(/\0/); - utf8::decode($_) for ($ref, $s); chomp $cd; my $align = length($ref) < 12 ? ' ' x (12 - length($ref)) : ''; print $zfh "$pfx ", ascii_html($ref), @@ -148,7 +147,6 @@ EOM } for (@r) { my (undef, $oid, $ref, $s, $cd) = split(/\0/); - utf8::decode($_) for ($ref, $s); chomp $cd; my $align = length($ref) < 12 ? ' ' x (12 - length($ref)) : ''; print $zfh "", ascii_html($ref), @@ -169,6 +167,7 @@ EOM sub capture_refs ($$) { # psgi_qx callback to capture git-for-each-ref + git-log my ($bref, $ctx) = @_; my $qsp_err = delete $ctx->{-qsp_err}; + utf8::decode($$bref); $ctx->{-each_refs} = $$bref; summary_finish($ctx) if $ctx->{-readme}; } -- cgit v1.2.3-24-ge0c7