From d2bbf647026a889700d9a62f79ef0875ca41b39a Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 17 Sep 2019 08:31:23 +0000 Subject: http: remove unnecessary delete Only removing $http->{env} is needed to prevent circular references. $env->{'psgix.io'} does not need to be deleted since $env will no longer have any references to it when ->close returns. --- lib/PublicInbox/HTTP.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index cd95f4ab..009b5ff0 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -453,9 +453,7 @@ sub quit { sub close { my $self = $_[0]; - if (my $env = delete $self->{env}) { - delete $env->{'psgix.io'}; # prevent circular references - } + delete $self->{env}; # prevent circular references if (my $forward = delete $self->{forward}) { eval { $forward->close }; err($self, "forward ->close error: $@") if $@; -- cgit v1.2.3-24-ge0c7