From b2daac64423db99db12bd77afe4da813c26ee1b6 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 10 Jan 2024 11:18:53 +0000 Subject: net_reader: fix NNTP credential use Clearly this was never tested until now, as passwords being retrieved by git-credential got completely ignored and unused. This enables users to connect to NNTP(S) servers requiring a password. --- lib/PublicInbox/NetReader.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm index e3e5d596..751043e9 100644 --- a/lib/PublicInbox/NetReader.pm +++ b/lib/PublicInbox/NetReader.pm @@ -291,7 +291,10 @@ sub nn_for ($$$$) { # nn = Net::NNTP return if $self->{quit}; $nn // die "E: <$uri> new: $@".onion_hint($lei, $uri); if ($cred) { - $cred->fill($lei) unless defined($p); # may prompt user here + $p //= do { + $cred->fill($lei); # may prompt user here + $cred->{password}; + }; if ($nn->authinfo($u, $p)) { push @{$nntp_cfg->{-postconn}}, [ 'authinfo', $u, $p ]; } else { -- cgit v1.2.3-24-ge0c7