From b1b3e733968845cfd0d9669198dd605717152db4 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 8 Jul 2019 07:31:19 +0000 Subject: http|nntp: "use PublicInbox::DS" instead of ->import Relying on "use" to import during BEGIN means we get to take advantage of prototype checking of function args during the rest of the compilation phase. --- lib/PublicInbox/HTTP.pm | 2 +- lib/PublicInbox/NNTP.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index 5546ac46..60b287c4 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -19,7 +19,7 @@ use HTTP::Status qw(status_message); use HTTP::Date qw(time2str); use IO::Handle; require PublicInbox::EvCleanup; -PublicInbox::DS->import(qw(msg_more)); +use PublicInbox::DS qw(msg_more); use PublicInbox::Syscall qw(EPOLLIN EPOLLONESHOT); use constant { CHUNK_START => -1, # [a-f0-9]+\r\n diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 6fee29f4..6796a3c4 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -14,7 +14,7 @@ use PublicInbox::Git; require PublicInbox::EvCleanup; use Email::Simple; use POSIX qw(strftime); -PublicInbox::DS->import(qw(now)); +use PublicInbox::DS qw(now); use Digest::SHA qw(sha1_hex); use Time::Local qw(timegm timelocal); use constant { -- cgit v1.2.3-24-ge0c7