From a090752ccc1bdbe5d90ec54dbecbb1a44f3f8091 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 13 Jul 2019 20:27:57 +0000 Subject: nntpdeflate: stop relying on SUPER for ->do_read We won't need further layering after enabling compression. So be explicit about which sub we're calling when we hit ->do_read from NNTP and eliminate the need for the comment. --- lib/PublicInbox/NNTPdeflate.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/NNTPdeflate.pm b/lib/PublicInbox/NNTPdeflate.pm index 10e2337c..f2de0f38 100644 --- a/lib/PublicInbox/NNTPdeflate.pm +++ b/lib/PublicInbox/NNTPdeflate.pm @@ -62,13 +62,13 @@ sub enable { # overrides PublicInbox::NNTP::compressed sub compressed { 1 } -# SUPER is PublicInbox::DS::do_read, so $_[1] may be a reference or not +# $_[1] may be a reference or not sub do_read ($$$$) { my ($self, $rbuf, $len, $off) = @_; my $zin = $self->{zin} or return; # closed my $deflated = \($zin->[1]); - my $r = $self->SUPER::do_read($deflated, $len) or return; + my $r = PublicInbox::DS::do_read($self, $deflated, $len) or return; # assert(length($$rbuf) == $off) as far as NNTP.pm is concerned # -ConsumeInput is true, so $deflated is automatically emptied -- cgit v1.2.3-24-ge0c7