From 8797a0b79d643824d05d0bd1a2b6e400081b855d Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 11 Jan 2017 04:12:27 +0000 Subject: async: improve and fix out-of-date comments --- lib/PublicInbox/HTTPD/Async.pm | 1 + lib/PublicInbox/Qspawn.pm | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm index 2bd19080..d3de4429 100644 --- a/lib/PublicInbox/HTTPD/Async.pm +++ b/lib/PublicInbox/HTTPD/Async.pm @@ -23,6 +23,7 @@ sub new { $self; } +# fires after pending writes are complete: sub restart_read_cb ($) { my ($self) = @_; sub { $self->watch_read(1) } diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index eead5a5b..cd23ab7f 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -86,8 +86,6 @@ sub psgi_return { $fh->close if $fh; # async-only }; - # Danga::Socket users, we queue up the read_enable callback to - # fire after pending writes are complete: my $buf = ''; my $rd_hdr = sub { my $r = sysread($rpipe, $buf, 1024, length($buf)); @@ -102,7 +100,7 @@ sub psgi_return { my $filter = delete $env->{'qspawn.filter'}; if (scalar(@$r) == 3) { # error if ($async) { - $async->close; # calls rpipe->close + $async->close; # calls rpipe->close and $end } else { $rpipe->close; $end->(); -- cgit v1.2.3-24-ge0c7