From 69ff4be6e7c8257834815dbdc0a2fd3563f6f350 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 24 Jan 2023 09:49:35 +0000 Subject: http: reuse STDIN if it's already /dev/null It's typical for -netd/-httpd to have STDIN pointed to /dev/null, so try to use that instead of opening another file description. --- lib/PublicInbox/HTTP.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index 0dba425d..ca162939 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -43,7 +43,13 @@ use Errno qw(EAGAIN); our $MAX_REQUEST_BUFFER = $ENV{GIT_HTTP_MAX_REQUEST_BUFFER} || (10 * 1024 * 1024); -open(my $null_io, '<', '/dev/null') or die "failed to open /dev/null: $!"; +open(my $null_io, '<', '/dev/null') or die "open /dev/null: $!"; +{ + my @n = stat($null_io) or die "stat(/dev/null): $!"; + my @i = stat(STDIN) or die "stat(STDIN): $!"; + $null_io = *STDIN{IO} if "@n[0, 1]" eq "@i[0, 1]"; +} + my $http_date; my $prev = 0; sub http_date () { -- cgit v1.2.3-24-ge0c7