From 56a20a3e242cc0a4c1df0ab1c77b3cebf3e33aae Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 18 Sep 2023 10:15:16 +0000 Subject: makefile: avoid non-POSIX which(1) which(1) isn't in POSIX so it's perhaps less likely to be available (although I don't think I've noticed a system without it in decades). So replace it with the POSIX `command -v', even though everyone seems to use which... Add a note about `lexgrog', too, since I'm not sure if it's packaged for various *BSDs. --- Documentation/include.mk | 2 ++ Makefile.PL | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/include.mk b/Documentation/include.mk index eb65454a..86851376 100644 --- a/Documentation/include.mk +++ b/Documentation/include.mk @@ -6,6 +6,8 @@ RSYNC = rsync RSYNC_DEST = public-inbox.org:/srv/public-inbox/ AWK = awk MAN = man + +# part of `man-db' on Debian, not sure about other distros LEXGROG = lexgrog # this is "xml" on FreeBSD and maybe some other distros: diff --git a/Makefile.PL b/Makefile.PL index 81992e46..8bd39e6c 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -126,7 +126,7 @@ my %man3 = map {; # semi-colon tells Perl this is a BLOCK (and not EXPR) "lib/PublicInbox/$_" => "blib/man3/PublicInbox::$mod.\$(MAN3EXT)" } qw(Git.pm Import.pm WWW.pod SaPlugin/ListMirror.pod); my $warn_no_pod = @no_pod ? "\n\t\@echo W: missing .pod: @no_pod\n" : ''; -chomp(my $lexgrog = `which lexgrog 2>/dev/null`); +chomp(my $lexgrog = `command -v lexgrog 2>/dev/null`); my $check_lexgrog = $lexgrog ? 'check-lexgrog' : ''; WriteMakefile( -- cgit v1.2.3-24-ge0c7