From 488211c1f3066cebfe5d74332527dcc790ddd740 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 18 Jan 2017 08:17:50 +0000 Subject: repobrowse: expath is always defined Remove an outdated comment while we're at it, too. --- lib/PublicInbox/RepobrowseGitPatch.pm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/RepobrowseGitPatch.pm b/lib/PublicInbox/RepobrowseGitPatch.pm index e8820f72..dc6cd793 100644 --- a/lib/PublicInbox/RepobrowseGitPatch.pm +++ b/lib/PublicInbox/RepobrowseGitPatch.pm @@ -26,11 +26,9 @@ sub call_git_patch { my $range = "$id~1..$id^0"; my @cmd = ('git', "--git-dir=$git->{git_dir}", @CMD, $sig." $range", $range, '--'); - if (defined(my $expath = $req->{expath})) { - push @cmd, $expath if $expath ne ''; - } + my $expath = $req->{expath}; + push @cmd, $expath if $expath ne ''; - # FIXME: generalize this with other qspawn users my $qsp = PublicInbox::Qspawn->new(\@cmd); $qsp->psgi_return($env, undef, sub { my ($r) = @_; -- cgit v1.2.3-24-ge0c7